atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test
Date Thu, 04 May 2017 18:08:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58945/#review173935
-----------------------------------------------------------


Fix it, then Ship it!





pom.xml
Line 1843 (original), 1843 (patched)
<https://reviews.apache.org/r/58945/#comment247010>

    does increasing the forkCount value >2 have an impact on the test running time?


- Sarath Subramanian


On May 4, 2017, 9:28 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58945/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 9:28 a.m.)
> 
> 
> Review request for atlas, Ayub Pathan, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues,
Sarath Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1753
>     https://issues.apache.org/jira/browse/ATLAS-1753
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Sandboxing DB instance for each folder by randomizing the folder name under target/data/berkly
and target/data/es. Allows the tests to be run in parallel too.
> 
> 
> Diffs
> -----
> 
>   graphdb/common/pom.xml 2b8d9abb 
>   graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java PRE-CREATION

>   graphdb/titan0/pom.xml 2db55140 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java
2dca50eb 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java
ade395be 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseValidationTest.java
1eccc7fc 
>   graphdb/titan1/pom.xml b147987c 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java
7f3a436a 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
6db0da83 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java
6b255f0a 
>   pom.xml 934be23c 
>   repository/pom.xml f1c38b45 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 6656dc67 
>   repository/src/test/java/org/apache/atlas/DBSandboxer.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/RepositoryServiceLoadingTest.java 6e13077e

>   repository/src/test/java/org/apache/atlas/TestOnlyModule.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/TestUtils.java f09aa5ac 
>   repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java
da2b4426 
>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
120187da 
>   repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java 6a1979a0

>   repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 7f5ed94e 
>   repository/src/test/java/org/apache/atlas/repository/graph/AbstractGremlinQueryOptimizerTest.java
2dda8536 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
f0424ab9 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
9f32b853 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java
174b8cb1 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java
5ac7c8fd 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerTest.java
1716ac53 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java
8f8aadcb 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 38319201

>   repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
a2fffe7a 
>   repository/src/test/java/org/apache/atlas/repository/graph/Gremlin2QueryOptimizerTest.java
b8572551 
>   repository/src/test/java/org/apache/atlas/repository/graph/Gremlin3QueryOptimizerTest.java
4045a4f9 
>   repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java
808305ca 
>   repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java
6e20ddda 
>   repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java
b87f7fd9 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java
a7c70a97 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceReportingTest.java
411299e3 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
131a6e1e 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
84ad72c8 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
f1c4e48f 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
acb80754 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateHardDeleteV1Test.java
8b5eaffc 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateSoftDeleteV1Test.java
0b3c5dba 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java
da12a773 
>   repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
c08bb881 
>   repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheConfigurationTest.java
e62af85f 
>   repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java
6c6c959e 
>   repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTestModule.java
a1d7a745 
>   repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java c6d7e9d1

>   repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java
b73cc867 
>   repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java c653710e

>   repository/src/test/java/org/apache/atlas/utils/HiveModel.java dbd4f42d 
>   repository/src/test/scala/org/apache/atlas/query/ExpressionTest.scala 7625786c 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala acc70b5e 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 004c29b4 
>   repository/src/test/scala/org/apache/atlas/query/LexerTest.scala 8d9cdaf8 
>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala bb44686c 
>   repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 878b0e38 
>   webapp/pom.xml 28bd7ea6 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 7badd1e6 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 3161a0da 
> 
> 
> Diff: https://reviews.apache.org/r/58945/diff/3/
> 
> 
> Testing
> -------
> 
> mvn clean package was successful with a 5 min speedup on my local mac laptop.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message