atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david_rad...@uk.ibm.com>
Subject Re: Review Request 58750: ATLAS-1744 Error when searching type with attribute name "order" , "limit" , "offset"
Date Tue, 02 May 2017 08:10:33 GMT


> On April 28, 2017, 12:40 p.m., David Radley wrote:
> > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/58750/diff/1/?file=1700686#file1700686line55>
> >
> >     I am not sure if I have understood this correctly. It seems that here is a a
configuration option that when set will allow attributes to be defined with the query keywords.
> >     
> >     I assume if the config utation option is then switched off, then Atlas will
need to deal with / delete any now invalid entities.
> 
> Suma Shivaprasad wrote:
>     The issue was that DSL does not with these keywords as attribute names unless they
are escaped with backquotes - pls see the test in GraphBackedDiscoveryServiceTest that was
added. When config allows keywords, then the backquotes need t be used in queries.

Hi Suma, I got that. Is it not the case that this config option covers behaviour at type creation
time and at search time. So if an invalid keyword type is created then the confiog option
is swtiched off- the search beviour will now not be consistent with the types created. Have
I missed something here ?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58750/#review173322
-----------------------------------------------------------


On April 29, 2017, 7:14 a.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58750/
> -----------------------------------------------------------
> 
> (Updated April 29, 2017, 7:14 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1744
>     https://issues.apache.org/jira/browse/ATLAS-1744
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added validation to reject type creations with attributes having reserved keywords with
a configuration to override this behaviour
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
dde263b 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala d9fd865 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java
9f69e5b 
> 
> 
> Diff: https://reviews.apache.org/r/58750/diff/2/
> 
> 
> Testing
> -------
> 
> Added UTS for both
> 
> 1.Testing Rejection of type creations with attributes having reserved keywords with a
configuration to override this behaviour
> 2.testing search with escape quotes
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message