atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 58746: Type validations with special character handling
Date Mon, 01 May 2017 23:56:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58746/
-----------------------------------------------------------

(Updated May 1, 2017, 11:56 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Suma
Shivaprasad.


Changes
-------

Ran into a wierd issue where the tests code causes the failure regardless of any product code
change.

Steps to reproduce:

1. Revert changes to the GraphBackedStoreTest class and run tests (runs fine)
2. Revert product code changes and run tests (runs fine)
3. Add the test without it being enabled (tests fail with no product changes)
4. Comment out the test and run (tests fail without any product changes)
5. Add product code changes and run the Test after reverting any changes to the test java
file (tests run fine)


Bugs: ATLAS-1730, ATLAS-1736 and ATLAS-1747
    https://issues.apache.org/jira/browse/ATLAS-1730
    https://issues.apache.org/jira/browse/ATLAS-1736
    https://issues.apache.org/jira/browse/ATLAS-1747


Repository: atlas


Description
-------

1. Added empty attribute(s) check 
2. Dealing with special characters like $,%,{,} (titan treats these specially)
3. Update of attribute type is not allowed anymore


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
6f1b80c8 
  repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
7037d1eb 


Diff: https://reviews.apache.org/r/58746/diff/4/

Changes: https://reviews.apache.org/r/58746/diff/3-4/


Testing
-------

mvn clean package executes successfully


Thanks,

Apoorv Naik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message