Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4E339200C55 for ; Thu, 13 Apr 2017 18:17:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4CBB9160B8B; Thu, 13 Apr 2017 16:17:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 93B85160BA7 for ; Thu, 13 Apr 2017 18:17:46 +0200 (CEST) Received: (qmail 95212 invoked by uid 500); 13 Apr 2017 16:17:45 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 95199 invoked by uid 99); 13 Apr 2017 16:17:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Apr 2017 16:17:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5A7FDC0742 for ; Thu, 13 Apr 2017 16:17:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4aZrkIE9T-6c for ; Thu, 13 Apr 2017 16:17:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EF3705FC7E for ; Thu, 13 Apr 2017 16:17:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6D498E0D40 for ; Thu, 13 Apr 2017 16:17:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D0EEA2406E for ; Thu, 13 Apr 2017 16:17:41 +0000 (UTC) Date: Thu, 13 Apr 2017 16:17:41 +0000 (UTC) From: "Graham Wallis (JIRA)" To: dev@atlas.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ATLAS-1733) No SIGKILL in python signal library on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 13 Apr 2017 16:17:47 -0000 [ https://issues.apache.org/jira/browse/ATLAS-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Graham Wallis updated ATLAS-1733: --------------------------------- Attachment: ATLAS-1733.patch Request participants: (was: ) > No SIGKILL in python signal library on Windows > ---------------------------------------------- > > Key: ATLAS-1733 > URL: https://issues.apache.org/jira/browse/ATLAS-1733 > Project: Atlas > Issue Type: Bug > Components: atlas-core > Affects Versions: 0.9-incubating > Environment: Windows 7 > Reporter: Graham Wallis > Assignee: Graham Wallis > Priority: Minor > Attachments: ATLAS-1733.patch > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > [I am new to Atlas and this is my first JIRA issue so apologies if I have omitted any necessary information or steps.] > There is no SIGKILL signal in the python signal library on Windows, so the import in atlas_stop.py fails. > There are two ways I can suggest that we fix it: > 1) introduce platform-specific code into atlas_stop.py > 2) wrap the python os.kill function > My preference is for the former as it is a small and localized change. > In either case the use of SIGTERM should be sufficient on Windows, as the existing python os.kill() function will open the process and terminate it, which is supposed to be equivalent to a SIGKILL (-9) on Linux. -- This message was sent by Atlassian JIRA (v6.3.15#6346)