Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Date: Thu, 13 Apr 2017 04:45:41 +0000 (UTC)
From: "Apoorv Naik (JIRA)" <jira@apache.org>
To: dev@atlas.incubator.apache.org
Message-ID: <JIRA.13061104.1491220090000.273027.1492058741930@Atlassian.JIRA>
In-Reply-To: <JIRA.13061104.1491220090000@Atlassian.JIRA>
References: <JIRA.13061104.1491220090000@Atlassian.JIRA> <JIRA.13061104.1491220090789@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ATLAS-1708) Incorrect error code while querying
 an entity for tag for which tag association is removed.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 13 Apr 2017 04:45:47 -0000


    [ https://issues.apache.org/jira/browse/ATLAS-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967127#comment-15967127 ] 

Apoorv Naik commented on ATLAS-1708:
------------------------------------

Can you add this condition to Line 302 in EntityGraphRetriever ?

{code}
if (CollectionUtils.isEmpty(classificationNames) || StringUtils.isNotEmpty(classificationNameFilter)) {
                //Should not reach here if classification present
                throw new AtlasBaseException(AtlasErrorCode.CLASSIFICATION_NOT_FOUND, classificationNameFilter);
            }
{code}

> Incorrect error code while querying an entity for tag for which tag association is removed.
> -------------------------------------------------------------------------------------------
>
>                 Key: ATLAS-1708
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1708
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: trunk, 0.9-incubating
>            Reporter: Sharmadha Sainath
>            Assignee: Sarath Subramanian
>         Attachments: ATLAS-1708.1.patch, EntityTagException.txt
>
>
> 1. Associated a tag PII to an entity.
> 2. /api/atlas/v2/entity/guid/{guid}/classification/PII GET query returned 200 OK.
> 3. Removed the PII tag from the entity.
> 4. /api/atlas/v2/entity/guid/{guid}/classification/PII GET query returned 500 Internal Server error. It should return 404 ideally.
> Attached the exception stack trace from application logs when GET query is fired.
> Note : When a tag is not associated to the entity at all, and when the same GET request is made with that tag name , 404 is returned.
> For example , Tag Personal is not associated to the entity and the same GET request with tag Personal returns 404 . *Only when a tag is associated and disassociated from an entity, GET request throws 500 internal server *


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)