Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BCE49200C4E for ; Fri, 21 Apr 2017 20:17:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BB9C1160B97; Fri, 21 Apr 2017 18:17:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0B5F3160B86 for ; Fri, 21 Apr 2017 20:17:51 +0200 (CEST) Received: (qmail 59896 invoked by uid 500); 21 Apr 2017 18:17:51 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 59885 invoked by uid 99); 21 Apr 2017 18:17:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Apr 2017 18:17:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8B0E6C08FE; Fri, 21 Apr 2017 18:17:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 05ar4_CGbhqS; Fri, 21 Apr 2017 18:17:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D88005F245; Fri, 21 Apr 2017 18:17:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3FEDCE0436; Fri, 21 Apr 2017 18:17:48 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 18F64C400D6; Fri, 21 Apr 2017 18:17:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8097318787319401359==" MIME-Version: 1.0 Subject: Re: Review Request 58588: [ATLAS-1742] : Provide option in server side to exclude deleted entities in basic and fulltext search From: Sarath Subramanian To: Apoorv Naik , Madhan Neethiraj , Ashutosh Mestry Cc: atlas , Sarath Subramanian Date: Fri, 21 Apr 2017 18:17:47 -0000 Message-ID: <20170421181747.23980.34041@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58588/ X-Sender: Sarath Subramanian References: <20170420192347.24124.27377@reviews-vm2.apache.org> In-Reply-To: <20170420192347.24124.27377@reviews-vm2.apache.org> Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Fri, 21 Apr 2017 18:17:52 -0000 --===============8097318787319401359== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58588/#review172692 ----------------------------------------------------------- repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Line 148 (original), 148 (patched) Yes, what you proposed is right. Default search behavior should not have deleted entities unless specified. So we still expose the historical flag as boolean flag in REST, to retrieve all deleted entities? - Sarath Subramanian On April 20, 2017, 12:23 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58588/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 12:23 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Suma Shivaprasad. > > > Bugs: ATLAS-1742 > https://issues.apache.org/jira/browse/ATLAS-1742 > > > Repository: atlas > > > Description > ------- > > Atlas UI needs to be enhanced to enable search on active entities in fulltext and basic search. This JIRA addresses the backend changes needed to enable this functionality. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 30d62a4b > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 07190dbf > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 836626b5 > > > Diff: https://reviews.apache.org/r/58588/diff/1/ > > > Testing > ------- > > testing in progress > > > Thanks, > > Sarath Subramanian > > --===============8097318787319401359==--