atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Wallis <graham_wal...@uk.ibm.com>
Subject Review Request 58422: Changed signal handling in atlas_stop.py for Windows
Date Thu, 13 Apr 2017 16:28:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58422/
-----------------------------------------------------------

Review request for atlas and David Radley.


Repository: atlas


Description
-------

On Windows there is no SIGKILL in the python signal library, so attempting to import SIGKILL
causes a fatal error.
This change introduces a platform switch that avoids trying to import SIGKILL and if the 30sec
timeout expires
it avoids attempting to use SIGKILL, instead using SIGTERM as the os.kill() function on Windows
will terminate
the process and should be as severe as a SIGKILL (kill -9) on a *nix system.


Diffs
-----

  distro/src/bin/atlas_stop.py a25d25aee599e7cc9ca3caaff8ff7f11b7e0c789 


Diff: https://reviews.apache.org/r/58422/diff/1/


Testing
-------

Functional testing manually verified


Thanks,

Graham Wallis


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message