Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 52F9C200C53 for ; Tue, 28 Mar 2017 07:22:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 51768160B99; Tue, 28 Mar 2017 05:22:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 986CE160B85 for ; Tue, 28 Mar 2017 07:22:01 +0200 (CEST) Received: (qmail 7446 invoked by uid 500); 28 Mar 2017 05:22:00 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 7395 invoked by uid 99); 28 Mar 2017 05:22:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2017 05:22:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 02E05C0974; Tue, 28 Mar 2017 05:22:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kU5mjUCqMR8K; Tue, 28 Mar 2017 05:21:59 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AD2415FB48; Tue, 28 Mar 2017 05:21:58 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 42232E002F; Tue, 28 Mar 2017 05:21:58 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 129ECC4125A; Tue, 28 Mar 2017 05:21:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1048461890951701370==" MIME-Version: 1.0 Subject: Re: Review Request 57978: Import API: Case where ZIP file Contains Deleted and Active Entities with Same QualifiedName From: Madhan Neethiraj To: Madhan Neethiraj Cc: Ashutosh Mestry , atlas Date: Tue, 28 Mar 2017 05:21:57 -0000 Message-ID: <20170328052157.28057.55981@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57978/ X-Sender: Madhan Neethiraj X-ReviewBoard-ShipIt: 1 References: <20170327224545.28056.24319@reviews-vm2.apache.org> In-Reply-To: <20170327224545.28056.24319@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas archived-at: Tue, 28 Mar 2017 05:22:02 -0000 --===============1048461890951701370== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57978/#review170258 ----------------------------------------------------------- Ship it! Ship It! - Madhan Neethiraj On March 27, 2017, 10:45 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57978/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 10:45 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1686 > https://issues.apache.org/jira/browse/ATLAS-1686 > > > Repository: atlas > > > Description > ------- > > Handled the case where incoming ZIP file contains deleted and active entities with same qualified name. > > Change to _IDBasedResolver_: > - Logic updated to retrieve vertex based on guid alone, if import is in progress. For all other operations, the old approach of continues. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java f53efe6 > > > Diff: https://reviews.apache.org/r/57978/diff/1/ > > > Testing > ------- > > Import -> Export -> Import and diff compare. > > > Thanks, > > Ashutosh Mestry > > --===============1048461890951701370==--