Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 03A03200C2D for ; Sat, 4 Mar 2017 08:51:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0250E160B71; Sat, 4 Mar 2017 07:51:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4A3CA160B66 for ; Sat, 4 Mar 2017 08:51:14 +0100 (CET) Received: (qmail 17912 invoked by uid 500); 4 Mar 2017 07:51:13 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 17896 invoked by uid 99); 4 Mar 2017 07:51:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Mar 2017 07:51:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E29ABC047B; Sat, 4 Mar 2017 07:51:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.203 X-Spam-Level: * X-Spam-Status: No, score=1.203 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id dnuZN7_b4dSc; Sat, 4 Mar 2017 07:51:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DED3D5FCD7; Sat, 4 Mar 2017 07:51:10 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2861DE00B4; Sat, 4 Mar 2017 07:51:10 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id F1AD9C40440; Sat, 4 Mar 2017 07:51:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4807884614230859348==" MIME-Version: 1.0 Subject: Re: Review Request 57302: [ATLAS-1630] : Basic search implementation using fulltext From: Sarath Subramanian To: Madhan Neethiraj Cc: Sarath Subramanian , atlas Date: Sat, 04 Mar 2017 07:51:09 -0000 Message-ID: <20170304075109.47990.58655@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57302/ X-Sender: Sarath Subramanian References: <20170304071018.47727.38384@reviews-vm2.apache.org> In-Reply-To: <20170304071018.47727.38384@reviews-vm2.apache.org> Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Sat, 04 Mar 2017 07:51:15 -0000 --===============4807884614230859348== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57302/ ----------------------------------------------------------- (Updated March 3, 2017, 11:51 p.m.) Review request for atlas and Madhan Neethiraj. Bugs: ATLAS-1630 https://issues.apache.org/jira/browse/ATLAS-1630 Repository: atlas Description ------- 1. Introduce a new search endpoint in DiscoveryREST called ‘/basic’ – this is in addition to existing /dsl and /fulltext 2. This method should take the following query parameters: a. query b. type c. classification d. limit e. offset 3. Given ‘query’ should be matched against ‘entityText’ attribute g.V().has(‘entityText’,com.thinkaurelius.titan.core.attribute.Text.CONTAINS, ‘query’) 4. If ‘type’ is provided, add the following filter: .has(‘__typeName’, T.in, [‘type’, ‘super-types-of-type’]) 5. If ‘classification’ is provided, add the following filter: .has(‘__traitNames’, T.in, [‘classification’, ‘super-types-of-classification’]) 6. limit/offset parameters.. Diffs (updated) ----- intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java c4c0063 intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 82b0310 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java c6be8f5 repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 21ce14d repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5628ed8 repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java e4777be repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java f076750 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 7f75a27 Diff: https://reviews.apache.org/r/57302/diff/6/ Changes: https://reviews.apache.org/r/57302/diff/5-6/ Testing ------- REST API testing suceeded. Thanks, Sarath Subramanian --===============4807884614230859348==--