Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============4489203365314806370=="
MIME-Version: 1.0
Subject: Re: Review Request 57241: [ATLAS-1621] : Fix webapp integration tests
 failures
From: Sarath Subramanian <sarath.kum4r@gmail.com>
To: Sarath Subramanian <sarath.kum4r@gmail.com>,
 Madhan Neethiraj <madhan@apache.org>, Apoorv Naik <naik.apoorv@gmail.com>,
 atlas <dev@atlas.incubator.apache.org>
Date: Thu, 02 Mar 2017 23:15:58 -0000
Message-ID: <20170302231558.39765.38874@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Sarath Subramanian <noreply@reviews.apache.org>
References: <20170302205847.39766.77018@reviews-vm2.apache.org>
In-Reply-To: <20170302205847.39766.77018@reviews-vm2.apache.org>
Reply-To: Sarath Subramanian <sarath.kum4r@gmail.com>
archived-at: Thu, 02 Mar 2017 23:16:04 -0000

--===============4489203365314806370==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


> On March 2, 2017, 12:58 p.m., Madhan Neethiraj wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
> > Line 262 (original), 264 (patched)
> > <https://reviews.apache.org/r/57241/diff/1/?file=1653517#file1653517line264>
> >
> >     Shouldn't an empty string be an invalid value for guid?

v2 apis supports: 
empty string for required attributes
empty/null string for optional attrs

doesnt support: 
null string for required attrs.


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57241/#review167730
-----------------------------------------------------------


On March 2, 2017, 3:03 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57241/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 3:03 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1621
>     https://issues.apache.org/jira/browse/ATLAS-1621
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Fix for the failed ITs:
> Failed tests:
> EntityJerseyResourceIT.testAddNullPropertyValue:423 Expected AtlasServiceException
> EntityJerseyResourceIT.testAddReferenceProperty:449->addProperty:467 Â» AtlasService
> EntityJerseyResourceIT.testEntityDeduping:264 Â» AtlasService Metadata service ...
> EntityJerseyResourceIT.testPartialUpdate:739 Â» AtlasService Metadata service A...
> EntityV2JerseyResourceIT.testAddNullPropertyValue:335->createHiveTable:443->createHiveTable:452 expected object to not be null
> EntityV2JerseyResourceIT.testEntityDeduping:197 Â» AtlasService Metadata servic...
> org.apache.atlas.web.resources.EntityV2JerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityV2JerseyResourceIT)
> Run 1: PASS
> Run 2: EntityV2JerseyResourceIT.testEntityInvalidValue:272 expected:<null> but was:<AtlasEntityHeader{guid='d8cd8064-25cf-490d-aa88-5a93392677de', status=ACTIVE, displayText=null, classificationNames=[],, AtlasStruct{typeName='hive_db_v2', attributes=[name:LMPplE6apZ]}}>
> EntityV2JerseyResourceIT.testSubmitEntity:103->createDBAndTable:437->createHiveTable:443->createHiveTable:452 expected object to not be null
> EntityV2JerseyResourceIT.testSubmitEntityWithBadDateFormat:296 expected object to not be null
> MetadataDiscoveryJerseyResourceIT.setUp:64->BaseResourceIT.createInstance:234 Â» AtlasService
> Tests run: 135, Failures: 10, Errors: 0, Skipped: 17
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java af7dbbf 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 61657a1 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java a3d951d 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java a198e61 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 6d902db 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 288ef82 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 0c1ffd3 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 0bcabb7 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b37dbca 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java e0e32a8 
> 
> 
> Diff: https://reviews.apache.org/r/57241/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean verify -pl webapp -DskipUTs - all ITs tests suceeded
> mvn clean install (in progress)
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


--===============4489203365314806370==--