Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 86F29200C39 for ; Thu, 2 Mar 2017 04:55:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8584F160B78; Thu, 2 Mar 2017 03:55:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CD619160B70 for ; Thu, 2 Mar 2017 04:54:59 +0100 (CET) Received: (qmail 69130 invoked by uid 500); 2 Mar 2017 03:54:58 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 69119 invoked by uid 99); 2 Mar 2017 03:54:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 03:54:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E254FC05AA for ; Thu, 2 Mar 2017 03:54:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.203 X-Spam-Level: * X-Spam-Status: No, score=1.203 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xWLXk5L3MuCH for ; Thu, 2 Mar 2017 03:54:56 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8D8C55F253 for ; Thu, 2 Mar 2017 03:54:56 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D86E8E00D5; Thu, 2 Mar 2017 03:54:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id CA4EBC40426; Thu, 2 Mar 2017 03:54:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4406253599543213908==" MIME-Version: 1.0 Subject: Re: Review Request 57230: ATLAS-1613: fix for bigdecimal value handling to avoid casting to long From: Suma Shivaprasad To: Madhan Neethiraj , atlas Date: Thu, 02 Mar 2017 03:54:54 -0000 Message-ID: <20170302035454.46018.57558@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57230/ X-Sender: Suma Shivaprasad References: <20170302033747.46018.46630@reviews-vm2.apache.org> In-Reply-To: <20170302033747.46018.46630@reviews-vm2.apache.org> Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas archived-at: Thu, 02 Mar 2017 03:55:00 -0000 --===============4406253599543213908== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57230/#review167646 ----------------------------------------------------------- intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java Line 369 (original), 371 (patched) should we change this to BigDecimal? - Suma Shivaprasad On March 2, 2017, 3:37 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57230/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 3:37 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1613 > https://issues.apache.org/jira/browse/ATLAS-1613 > > > Repository: atlas > > > Description > ------- > > - fix for bigdecimal value handling to avoid casting to long > - fixed incorrect HTTP status code for an error > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ad362c > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 600ef8c > > > Diff: https://reviews.apache.org/r/57230/diff/1/ > > > Testing > ------- > > - verified that big decimal attributes values are stored as given in the input (like 1.7976931348623157e+308), instead of trimming to nearest long value). > > > Thanks, > > Madhan Neethiraj > > --===============4406253599543213908==--