Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 14377200C2A for ; Wed, 1 Mar 2017 19:26:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 12CC5160B70; Wed, 1 Mar 2017 18:26:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5B3F6160B56 for ; Wed, 1 Mar 2017 19:26:36 +0100 (CET) Received: (qmail 27350 invoked by uid 500); 1 Mar 2017 18:26:35 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 27339 invoked by uid 99); 1 Mar 2017 18:26:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 18:26:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B65E91895B9; Wed, 1 Mar 2017 18:26:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.203 X-Spam-Level: * X-Spam-Status: No, score=1.203 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3v3jkJuej2VM; Wed, 1 Mar 2017 18:26:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D23705F1EE; Wed, 1 Mar 2017 18:26:32 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6FA17E0238; Wed, 1 Mar 2017 18:26:31 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6192DC403EF; Wed, 1 Mar 2017 18:26:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5023494523293680253==" MIME-Version: 1.0 Subject: Re: Review Request 57210: ATLAS-1587: updated AtlasEntityHeader retrieval to read name/description/owner attributes defined in the type (instead of Asset) From: Apoorv Naik To: Madhan Neethiraj , Apoorv Naik , atlas Date: Wed, 01 Mar 2017 18:26:31 -0000 Message-ID: <20170301182631.39251.9704@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57210/ X-Sender: Apoorv Naik X-ReviewBoard-ShipIt: 1 References: <20170301180910.39251.78511@reviews-vm2.apache.org> In-Reply-To: <20170301180910.39251.78511@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Wed, 01 Mar 2017 18:26:37 -0000 --===============5023494523293680253== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57210/#review167412 ----------------------------------------------------------- Ship it! Ship It! - Apoorv Naik On March 1, 2017, 6:09 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57210/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 6:09 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1587 > https://issues.apache.org/jira/browse/ATLAS-1587 > > > Repository: atlas > > > Description > ------- > > - Consolidated the logic to populate AtlasEntityHeader from a vertext to EntityGraphRetriever.toAtlasEntityHeader() > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java e3eb52a > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java da06230 > repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 4a98920 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 44ca854 > > > Diff: https://reviews.apache.org/r/57210/diff/2/ > > > Testing > ------- > > - verified that the header has correct value for 'name' even for types not derived from Asset (like storm_spout) > > > Thanks, > > Madhan Neethiraj > > --===============5023494523293680253==--