atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 57321: ATLAS-1630: fix incorrect pagination of results in basic search; use index-search when query is provided (#3)
Date Sun, 05 Mar 2017 19:30:34 GMT


> On March 5, 2017, 7:11 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
> > Lines 212 (patched)
> > <https://reviews.apache.org/r/57321/diff/1/?file=1656432#file1656432line216>
> >
> >     add empty check for typeNames

typeNames will either be null (when no type filter is specified) or will have atleast one
entry - line #182. Hence only checking for null here.


> On March 5, 2017, 7:11 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
> > Lines 224 (patched)
> > <https://reviews.apache.org/r/57321/diff/1/?file=1656432#file1656432line228>
> >
> >     !CollectionUtils.containsAny(classificationNames, GraphHelper.getTraitNames(vertex)))
{ ==> !CollectionUtils.containsAny(classificationNames, traitNames) {

Good catch. Thanks.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57321/#review167945
-----------------------------------------------------------


On March 5, 2017, 7:30 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57321/
> -----------------------------------------------------------
> 
> (Updated March 5, 2017, 7:30 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1630
>     https://issues.apache.org/jira/browse/ATLAS-1630
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - updated basic-search implementation to use direct-index-search when query string is
provided. This results in faster/accurate results
> - fixed incorrect pagination of results in basic search
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java e1f0acd

>   repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 8855246

>   repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java ad8f073

> 
> 
> Diff: https://reviews.apache.org/r/57321/diff/2/
> 
> 
> Testing
> -------
> 
> - verified that basic-search pagination issue is fixed
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message