atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 57302: [ATLAS-1630] : Basic search implementation using fulltext
Date Sat, 04 Mar 2017 07:51:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57302/
-----------------------------------------------------------

(Updated March 3, 2017, 11:51 p.m.)


Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-1630
    https://issues.apache.org/jira/browse/ATLAS-1630


Repository: atlas


Description
-------

1. Introduce a new search endpoint in DiscoveryREST called ‘/basic’ – this is in addition
to existing /dsl and /fulltext
2. This method should take the following query parameters:
    a. query
    b. type
    c. classification
    d. limit
    e. offset
3. Given ‘query’ should be matched against ‘entityText’ attribute
    g.V().has(‘entityText’,com.thinkaurelius.titan.core.attribute.Text.CONTAINS, ‘query’)
4. If ‘type’ is provided, add the following filter:
    .has(‘__typeName’, T.in, [‘type’, ‘super-types-of-type’])
5. If ‘classification’ is provided, add the following filter:
    .has(‘__traitNames’, T.in, [‘classification’, ‘super-types-of-classification’])
6. limit/offset parameters..


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java c4c0063 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 82b0310 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java c6be8f5 
  repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 21ce14d 
  repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 5628ed8

  repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java e4777be 
  repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java f076750 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 7f75a27 


Diff: https://reviews.apache.org/r/57302/diff/6/

Changes: https://reviews.apache.org/r/57302/diff/5-6/


Testing
-------

REST API testing suceeded.


Thanks,

Sarath Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message