atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 57224: Export API: Scoped Export
Date Fri, 03 Mar 2017 04:34:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57224/
-----------------------------------------------------------

(Updated March 3, 2017, 4:34 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Added group.


Bugs: ATLAS-1618
    https://issues.apache.org/jira/browse/ATLAS-1618


Repository: atlas


Description
-------

Patch has following items:
* _Import_: 
    - Support for Import of classification associated with Entities during Import. This was
not functional earlier.
    - Fixed/updated type creation during import.
* _Export_: 
    - Refactoring for _Export_ related to _Gremlin Query Provider_.
    - Scoped export. Please refer to [ATLAS-1618](https://issues.apache.org/jira/browse/ATLAS-1618)
for details. See CURL below.

*CURL*

_*Full Export*_

```
curl -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
-d '{
  "itemsToExport": [
      {
          "typeName": "DB_v1",
          "uniqueAttributes": {
              "name": "Sales"
          }
    }
  ],
  "options": { "FETCH": "full" }
}
' "http://localhost:21000/api/atlas/admin/export" > ../docs/Sales_v1-Full.zip
```

_*Connected Export*_
```
curl -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
-d '{
  "itemsToExport": [
      {
          "typeName": "DB_v1",
          "uniqueAttributes": {
              "name": "Sales"
          }
    }
  ],
  "options": { "FETCH": "full" }
}
' "http://localhost:21000/api/atlas/admin/export" > ../docs/Sales_v1-Full.zip
```


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java dcb2765 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 61657a1

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
a3d951d 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStreamForImport.java
c0b4d8d 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityImportStream.java
51ae312 
  repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 798ce38 
  repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java ad22bf7 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java f11d2d1 
  webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java df8bf33 
  webapp/src/main/java/org/apache/atlas/web/resources/ImportService.java 1bd705d 
  webapp/src/main/java/org/apache/atlas/web/resources/ZipSource.java 4596084 


Diff: https://reviews.apache.org/r/57224/diff/4/


Testing
-------

Accuracy check: For _Quick Start v1_ verified using _Export -> Import -> Export and
folder diff_.
Performance metrics. See file attached.
Functional tests for old and new Export options.


File Attachments
----------------

Performance Metrics
  https://reviews.apache.org/media/uploaded/files/2017/03/01/6099d841-d7e8-4b28-9940-8f63a9405da1__Atlas-Import-Performance.xlsx


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message