atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 57241: [ATLAS-1621] : Fix webapp integration tests failures
Date Thu, 02 Mar 2017 20:58:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57241/#review167730
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
Lines 294 (patched)
<https://reviews.apache.org/r/57241/#comment239651>

    Instead of assuming attrValue to be always the guid, Consider thw followign, to process
attrValue of type Map and AtlasObjectId:
    
    AtlasObjectId objId;
    if (attrValue instanceof String) {
      objId = new AtlasObjectId((String)attrValue);
    } else {
      objId = attrType.getNormalizedValue(attrValue);
    }



webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
Line 262 (original), 264 (patched)
<https://reviews.apache.org/r/57241/#comment239652>

    Shouldn't an empty string be an invalid value for guid?



webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
Lines 634 (patched)
<https://reviews.apache.org/r/57241/#comment239654>

    Consider replacing this with:
    
      AtlasEntitiesWithExtInfo entityInfo = new AtlasEntitiesWithExtInfo(tableUpdated);
    
      for (AtlasEntity column : columns)
        entityInfo.addReferredEntity(column);
        
        
    Review line #659, #660 & #699, #700 as well.


- Madhan Neethiraj


On March 2, 2017, 11:16 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57241/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 11:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1621
>     https://issues.apache.org/jira/browse/ATLAS-1621
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Fix for the failed ITs:
> Failed tests:
> EntityJerseyResourceIT.testAddNullPropertyValue:423 Expected AtlasServiceException
> EntityJerseyResourceIT.testAddReferenceProperty:449->addProperty:467 » AtlasService
> EntityJerseyResourceIT.testEntityDeduping:264 » AtlasService Metadata service ...
> EntityJerseyResourceIT.testPartialUpdate:739 » AtlasService Metadata service A...
> EntityV2JerseyResourceIT.testAddNullPropertyValue:335->createHiveTable:443->createHiveTable:452
expected object to not be null
> EntityV2JerseyResourceIT.testEntityDeduping:197 » AtlasService Metadata servic...
> org.apache.atlas.web.resources.EntityV2JerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityV2JerseyResourceIT)
> Run 1: PASS
> Run 2: EntityV2JerseyResourceIT.testEntityInvalidValue:272 expected:<null> but
was:<AtlasEntityHeader{guid='d8cd8064-25cf-490d-aa88-5a93392677de', status=ACTIVE, displayText=null,
classificationNames=[],, AtlasStruct{typeName='hive_db_v2', attributes=[name:LMPplE6apZ]}}>
> EntityV2JerseyResourceIT.testSubmitEntity:103->createDBAndTable:437->createHiveTable:443->createHiveTable:452
expected object to not be null
> EntityV2JerseyResourceIT.testSubmitEntityWithBadDateFormat:296 expected object to not
be null
> MetadataDiscoveryJerseyResourceIT.setUp:64->BaseResourceIT.createInstance:234 »
AtlasService
> Tests run: 135, Failures: 10, Errors: 0, Skipped: 17
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
61657a1 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
a3d951d 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 6d902db 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 0bcabb7 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b37dbca

>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java e0e32a8

> 
> 
> Diff: https://reviews.apache.org/r/57241/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean verify -pl webapp -DskipUTs - all ITs tests suceeded
> mvn clean install (in progress)
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message