atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 57230: ATLAS-1613: fix for bigdecimal value handling to avoid casting to long
Date Thu, 02 Mar 2017 03:54:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57230/#review167646
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java
Line 369 (original), 371 (patched)
<https://reviews.apache.org/r/57230/#comment239555>

    should we change this to BigDecimal?


- Suma Shivaprasad


On March 2, 2017, 3:37 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57230/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 3:37 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1613
>     https://issues.apache.org/jira/browse/ATLAS-1613
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - fix for bigdecimal value handling to avoid casting to long
> - fixed incorrect HTTP status code for an error
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ad362c 
>   intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 600ef8c 
> 
> 
> Diff: https://reviews.apache.org/r/57230/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that big decimal attributes values are stored as given in the input (like
1.7976931348623157e+308), instead of trimming to nearest long value).
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message