atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 57210: ATLAS-1587: updated AtlasEntityHeader retrieval to read name/description/owner attributes defined in the type (instead of Asset)
Date Wed, 01 Mar 2017 18:09:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57210/
-----------------------------------------------------------

(Updated March 1, 2017, 6:09 p.m.)


Review request for atlas.


Changes
-------

Removed file that had only 'import' changes


Bugs: ATLAS-1587
    https://issues.apache.org/jira/browse/ATLAS-1587


Repository: atlas


Description
-------

- Consolidated the logic to populate AtlasEntityHeader from a vertext to EntityGraphRetriever.toAtlasEntityHeader()


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java e3eb52a 
  repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java da06230

  repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 4a98920 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
44ca854 


Diff: https://reviews.apache.org/r/57210/diff/2/

Changes: https://reviews.apache.org/r/57210/diff/1-2/


Testing
-------

- verified that the header has correct value for 'name' even for types not derived from Asset
(like storm_spout)


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message