atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neeru Gupta <guptane...@us.ibm.com>
Subject Re: Review Request 56289: Atlas-695: Add Titan1 suport in Atlas.
Date Wed, 01 Mar 2017 16:56:26 GMT


> On Feb. 9, 2017, 3 a.m., Jeff Hagelberg wrote:
> > graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
> > Lines 54 (patched)
> > <https://reviews.apache.org/r/56289/diff/1/?file=1625318#file1625318line54>
> >
> >     There are unit test failures in this class that need to be fixed:
> >     
> >     
> >     Failed tests:
> >       GraphQueryTest>AbstractGraphDatabaseTest.createIndices:57 ? ClassCast com.thin...
> >       Titan1DatabaseTest.cleanup:79 NullPointer
> >       Titan1DatabaseTest.getGetGraphQueryForVertices:347->getGraph:61 ? ClassCast
co...
> >       Titan1DatabaseTest.testAddMultManyPropertyValueTwice:399->getGraph:61 ?
ClassCast
> >       Titan1DatabaseTest.testGetEdges:221->getGraph:61 ? ClassCast com.thinkaurelius...
> >       Titan1DatabaseTest.testListProperties:296->getGraph:61 ? ClassCast com.thinkau...
> >       Titan1DatabaseTest.testMultiplicityOnePropertySupport:149->getGraph:61
? ClassCast
> >       Titan1DatabaseTest.testMultiplictyManyPropertySupport:257->getGraph:61
? ClassCast
> >       Titan1DatabaseTest.testPropertyDataTypes:88->getGraph:61 ? ClassCast com.think...
> >       Titan1DatabaseTest.testRemoveEdge:185->getGraph:61 ? ClassCast com.thinkaureli...
> >       Titan1DatabaseTest.testRemoveProperty:319->getGraph:61 ? ClassCast com.thinkau...
> >       Titan1DatabaseTest.testRemoveVertex:207->getGraph:61 ? ClassCast com.thinkaure...

Fixed by Jeff.


- Neeru


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56289/#review164799
-----------------------------------------------------------


On Feb. 27, 2017, 8:40 p.m., Neeru Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56289/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 8:40 p.m.)
> 
> 
> Review request for atlas, David Kantor and Jeff Hagelberg.
> 
> 
> Bugs: ATLAS-695
>     https://issues.apache.org/jira/browse/ATLAS-695
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-695 Add titan1 project in atlas
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml 00e56dc6d01959f81a2d0884396837e261cb3ff0 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 6a2ba53ddfc740bf77baf319b458853bd33864ec

>   catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 901a549a8945d7314373feac8b9a5fea1340a85d

>   graphdb/graphdb-impls/pom.xml 57b5137178dd179f86edb9a7af4f260b4b7d0ece 
>   graphdb/pom.xml 2d303e4d5c29943ceef7883f3ad10a366d7f26aa 
>   graphdb/titan0/pom.xml 9d88a72f60a3fa6969a94bf62f40d0192781c199 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
75ea54511535ab72b5d00e7c5d8a1eccaffc3ef2 
>   graphdb/titan0/src/main/java/org/apache/atlas/utils/IteratorToIterableAdapter.java
ed7c2a71ed1f12470a0a19e475adb145282c1681 
>   graphdb/titan1/pom.xml PRE-CREATION 
>   graphdb/titan1/readme.txt PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/resources/atlas-application.properties PRE-CREATION 
>   pom.xml 798e965fa03c311728777d61bb1ec439caf5e1ee 
>   repository/src/test/java/org/apache/atlas/TestUtils.java e5abd7717ae965c91eed64cd106acc885dc5bc4d

>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
a90543e9b66a27c85e3c31b097d55aca4ac20c6c 
>   repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java 19124d7792396a41f95198aec1668e4132b94c76

>   repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
7ea15cb1c667cdd1e43537665c68b7959c031a53 
>   repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryTest.java
79550baca67ebafae4da3b679bfbb00e00c8d225 
>   webapp/pom.xml e7dce78e91fb623e5b16144db2b82f0f03d1ec2e 
> 
> 
> Diff: https://reviews.apache.org/r/56289/diff/9/
> 
> 
> Testing
> -------
> 
> This review request contains titan 1 project and related changes. Titan 1 project is
disabled by default. It gets enabled when titan1 profile is enabled. Titan1 project needs
java 8 to build. While building on Java7, the java classes for project are not compiled and
titan1 tests are skipped. Build creates an empty titan1 jar file. While using Java8, titan1
classes are compiled but tests are only run if titan1 profile is enabled.
> 
> More changes may require to bring Atlas up with Titan1. Please refer to read me file
for known issues in bringing the Atlas server up with titan1. This serves as initial implementation
to support Titan1.
> 
> Some tests in repository and webapp project are skipped with titan1 profile. Those tests
currently are using Gremlin2 syntax. Titan1 requires Gremlin3 syntax. I have created atlas
jira issues to address those test failures.
> 
> It was a team effort at IBM. Jeff Hagelberg has contributed in this project.
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message