Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96E72200C24 for ; Thu, 23 Feb 2017 19:20:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9593B160B64; Thu, 23 Feb 2017 18:20:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D43F4160B3E for ; Thu, 23 Feb 2017 19:20:15 +0100 (CET) Received: (qmail 78670 invoked by uid 500); 23 Feb 2017 18:20:15 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 78659 invoked by uid 99); 23 Feb 2017 18:20:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2017 18:20:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 506CCC0605 for ; Thu, 23 Feb 2017 18:20:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.819 X-Spam-Level: X-Spam-Status: No, score=-0.819 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5hFUDbl_2_uP for ; Thu, 23 Feb 2017 18:20:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id BEF1E618B0 for ; Thu, 23 Feb 2017 18:20:11 +0000 (UTC) Received: (qmail 77796 invoked by uid 99); 23 Feb 2017 18:19:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2017 18:19:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 191CD1C0551; Thu, 23 Feb 2017 18:19:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0868609384755567566==" MIME-Version: 1.0 Subject: Re: Review Request 56969: [ATLAS-1564] : EntityResource v1 should start routing its calls to v2 EntityREST From: Sarath Subramanian To: Vimal Sharma , Apoorv Naik , Madhan Neethiraj , Ashutosh Mestry Cc: Sarath Subramanian , atlas Date: Thu, 23 Feb 2017 18:19:56 -0000 Message-ID: <20170223181956.1738.15744@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56969/ X-Sender: Sarath Subramanian References: <20170223075150.1738.67817@reviews.apache.org> In-Reply-To: <20170223075150.1738.67817@reviews.apache.org> Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Thu, 23 Feb 2017 18:20:16 -0000 --===============0868609384755567566== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56969/ ----------------------------------------------------------- (Updated Feb. 23, 2017, 10:19 a.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma. Changes ------- included classification attributes when conversion from AtlasClassification to Referenceable. Bugs: ATLAS-1564 https://issues.apache.org/jira/browse/ATLAS-1564 Repository: atlas Description ------- With the v2 implementation of EntityREST ready, we must start routing all v1 entity CRUD calls to start using v2 APIs in EntityREST. Diffs (updated) ----- client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 1ce6168 repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java 9d0d7f4 repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java e14fafb repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7 repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java 6b6ee01 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 3a037cc repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java bbfc3e5 repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5127f74 server-api/src/main/java/org/apache/atlas/services/MetadataService.java e0fb66c typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 8cad2f8 typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 2f2b090 webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f59cd9d webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11 Diff: https://reviews.apache.org/r/56969/diff/ Testing ------- mvn clean package - all tests passed. Thanks, Sarath Subramanian --===============0868609384755567566==--