Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============1239042559192078199=="
MIME-Version: 1.0
Subject: Re: Review Request 56289: Atlas-695: Add Titan1 suport in Atlas.
From: Jeff Hagelberg <jnhagelberg@us.ibm.com>
To: Jeff Hagelberg <jnhagelberg@us.ibm.com>, David Kantor <dkantor@us.ibm.com>
Cc: atlas <dev@atlas.incubator.apache.org>, Apoorv Naik <naik.apoorv@gmail.com>,
 Neeru Gupta <guptaneeru@us.ibm.com>
Date: Fri, 17 Feb 2017 21:32:11 -0000
Message-ID: <20170217213211.10109.72195@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Jeff Hagelberg <noreply@reviews.apache.org>
References: <20170217160027.17007.74767@reviews.apache.org>
In-Reply-To: <20170217160027.17007.74767@reviews.apache.org>
Reply-To: Jeff Hagelberg <jnhagelberg@us.ibm.com>
archived-at: Fri, 17 Feb 2017 21:32:21 -0000

--===============1239042559192078199==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56289/#review165974
-----------------------------------------------------------


repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java (line 279)
<https://reviews.apache.org/r/56289/#comment237837>

    whitepace


repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java (line 282)
<https://reviews.apache.org/r/56289/#comment237835>

    It may be better to throw a SkipException here.  This way, the test will be correctly reported as being skipped rather than passing.


- Jeff Hagelberg


On Feb. 17, 2017, 4 p.m., Neeru Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56289/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 4 p.m.)
> 
> 
> Review request for atlas, David Kantor and Jeff Hagelberg.
> 
> 
> Bugs: ATLAS-695
>     https://issues.apache.org/jira/browse/ATLAS-695
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-695 Add titan1 project in atlas
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml 00e56dc6d01959f81a2d0884396837e261cb3ff0 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 6a2ba53ddfc740bf77baf319b458853bd33864ec 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 901a549a8945d7314373feac8b9a5fea1340a85d 
>   graphdb/graphdb-impls/pom.xml 57b5137178dd179f86edb9a7af4f260b4b7d0ece 
>   graphdb/pom.xml 2d303e4d5c29943ceef7883f3ad10a366d7f26aa 
>   graphdb/titan0/pom.xml 9d88a72f60a3fa6969a94bf62f40d0192781c199 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 75ea54511535ab72b5d00e7c5d8a1eccaffc3ef2 
>   graphdb/titan0/src/main/java/org/apache/atlas/utils/IteratorToIterableAdapter.java ed7c2a71ed1f12470a0a19e475adb145282c1681 
>   graphdb/titan1/pom.xml PRE-CREATION 
>   graphdb/titan1/readme.txt PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java PRE-CREATION 
>   graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java PRE-CREATION 
>   graphdb/titan1/src/test/resources/atlas-application.properties PRE-CREATION 
>   pom.xml 834ecae05ac73b2c42b61d2b4115f052a3c45ea8 
>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ffda9849e9632bff6764aed70c76a2f50f493d0d 
>   webapp/pom.xml 5dc74019810cf8cd5b59d256e69f602c561119a0 
> 
> Diff: https://reviews.apache.org/r/56289/diff/
> 
> 
> Testing
> -------
> 
> This review request contains titan 1 project and related changes. Titan 1 project is disabled by default. It gets enabled when titan1 profile is enabled. It requires Java 8.
> 
> More changes may require to bring Atlas up with Titan1. This serves as initial implementation to support Titan1.
> 
> It was a team effort at IBM. Jeff Hagelberg has contributed in this project.
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>


--===============1239042559192078199==--