Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B71F4200C1C for ; Wed, 15 Feb 2017 09:39:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B5BC5160B5E; Wed, 15 Feb 2017 08:39:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 081A4160B46 for ; Wed, 15 Feb 2017 09:39:34 +0100 (CET) Received: (qmail 88303 invoked by uid 500); 15 Feb 2017 08:39:34 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 88292 invoked by uid 99); 15 Feb 2017 08:39:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Feb 2017 08:39:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6B8311A041D for ; Wed, 15 Feb 2017 08:39:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 28UxrHE-oCka for ; Wed, 15 Feb 2017 08:39:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 118685F659 for ; Wed, 15 Feb 2017 08:39:30 +0000 (UTC) Received: (qmail 86137 invoked by uid 99); 15 Feb 2017 08:38:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Feb 2017 08:38:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6BBA81C1D0C; Wed, 15 Feb 2017 08:38:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5702869768675268976==" MIME-Version: 1.0 Subject: Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for entity partial update From: Sarath Subramanian To: Sarath Subramanian , Madhan Neethiraj , atlas Date: Wed, 15 Feb 2017 08:38:29 -0000 Message-ID: <20170215083829.13056.34832@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56651/ X-Sender: Sarath Subramanian References: <20170215015453.13057.11656@reviews.apache.org> In-Reply-To: <20170215015453.13057.11656@reviews.apache.org> X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java.orig Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Wed, 15 Feb 2017 08:39:35 -0000 --===============5702869768675268976== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56651/ ----------------------------------------------------------- (Updated Feb. 15, 2017, 12:38 a.m.) Review request for atlas. Changes ------- * added implementation of isValidValueForUpdate(), getNormalizedValueForUpdate() and validateValueForUpdate() for array and map types. * additional test case to test partial updates on array of entities (columns) Bugs: ATLAS-1554 https://issues.apache.org/jira/browse/ATLAS-1554 Repository: atlas Description ------- Add REST endpoints to enable partial update of entity using unique attributes and implement the same. Diffs (updated) ----- intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 74acfdc intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java.orig PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725 intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83 intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563 repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java a12ba3b repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 256c5f6 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 6a1b301 repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288 repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java e812ca6 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7 Diff: https://reviews.apache.org/r/56651/diff/ Testing (updated) ------- mvn clean package - Build succeeded will all tests passed. mvn clean install - usual failiure in webapp modules TaxonomyServiceTest Thanks, Sarath Subramanian --===============5702869768675268976==--