Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39FF1200C23 for ; Wed, 8 Feb 2017 01:47:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 38C23160B69; Wed, 8 Feb 2017 00:47:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 84129160B3E for ; Wed, 8 Feb 2017 01:47:51 +0100 (CET) Received: (qmail 81862 invoked by uid 500); 8 Feb 2017 00:47:50 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 81851 invoked by uid 99); 8 Feb 2017 00:47:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2017 00:47:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F340C18C458 for ; Wed, 8 Feb 2017 00:47:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.768 X-Spam-Level: X-Spam-Status: No, score=-4.768 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id nD_hAyXjbBwm for ; Wed, 8 Feb 2017 00:47:48 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 097E55F24B for ; Wed, 8 Feb 2017 00:47:47 +0000 (UTC) Received: (qmail 81733 invoked by uid 99); 8 Feb 2017 00:47:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2017 00:47:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 948CB2DF8A8; Wed, 8 Feb 2017 00:47:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8389140286693072380==" MIME-Version: 1.0 Subject: Review Request 56417: ATLAS-1535: Some webapp tests are failing due to a stale Titan transaction From: Jeff Hagelberg To: David Kantor Cc: Jeff Hagelberg , atlas Date: Wed, 08 Feb 2017 00:47:46 -0000 Message-ID: <20170208004746.31774.47742@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jeff Hagelberg X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56417/ X-Sender: Jeff Hagelberg X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/filters/StaleTransactionCleanupFilter.java Reply-To: Jeff Hagelberg X-ReviewRequest-Repository: atlas archived-at: Wed, 08 Feb 2017 00:47:52 -0000 --===============8389140286693072380== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56417/ ----------------------------------------------------------- Review request for atlas and David Kantor. Bugs: ATLAS-1535 https://issues.apache.org/jira/browse/ATLAS-1535 Repository: atlas Description ------- I've added a new filter to consistently clean up stale transactions when processing http requests. I removed the old logic, which was only used by two service classes. The new filter is used everywhere. Diffs ----- webapp/src/main/java/org/apache/atlas/web/filters/StaleTransactionCleanupFilter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java d0437fc54087e6803ead83af59b85e9f6df333ad webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java fb77b11e04c875a3d443dfb49be50cb818bed441 webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java e1734e465ad553d95735b466f4dfe0fa8ad061b8 Diff: https://reviews.apache.org/r/56417/diff/ Testing ------- Ran webapp tests. Now, we're only left with the following failures: QuickStartIT.runQuickStart:44 » AtlasService Metadata service API org.apache.a... QuickStartV2IT.runQuickStart:47 » AtlasService Metadata service API org.apache... NotificationHookConsumerIT.testUpdatePartialUpdatingQualifiedName:170 expected:<0> but was:<1> Previously, there were a number of other tests that were failing sporatically with a NullPointerException coming from Titan. These changes fix that. Thanks, Jeff Hagelberg --===============8389140286693072380==--