Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 16C7A200C1E for ; Fri, 3 Feb 2017 00:50:41 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 156A8160B61; Thu, 2 Feb 2017 23:50:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5F610160B57 for ; Fri, 3 Feb 2017 00:50:40 +0100 (CET) Received: (qmail 73639 invoked by uid 500); 2 Feb 2017 23:50:39 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 73627 invoked by uid 99); 2 Feb 2017 23:50:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 23:50:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E658B18285E for ; Thu, 2 Feb 2017 23:50:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id r0dc8ST-ymNX for ; Thu, 2 Feb 2017 23:50:37 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id E48A75F5F8 for ; Thu, 2 Feb 2017 23:50:36 +0000 (UTC) Received: (qmail 73609 invoked by uid 99); 2 Feb 2017 23:50:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 23:50:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E82972DF988; Thu, 2 Feb 2017 23:50:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4599109005353998862==" MIME-Version: 1.0 Subject: Review Request 56260: [ATLAS-1523] Implement GET entity by guid and unique attributes in V2 Entity API using AtlasObjectID From: Sarath Subramanian To: Vimal Sharma , Apoorv Naik , Madhan Neethiraj Cc: Sarath Subramanian , atlas Date: Thu, 02 Feb 2017 23:50:35 -0000 Message-ID: <20170202235035.1724.67529@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56260/ X-Sender: Sarath Subramanian X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Thu, 02 Feb 2017 23:50:41 -0000 --===============4599109005353998862== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56260/ ----------------------------------------------------------- Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma. Bugs: ATLAS-1523 https://issues.apache.org/jira/browse/ATLAS-1523 Repository: atlas Description ------- Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity. Diffs ----- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 4c79cef repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java PRE-CREATION Diff: https://reviews.apache.org/r/56260/diff/ Testing ------- Tested using POSTMAN Thanks, Sarath Subramanian --===============4599109005353998862==--