Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2F22F200C0F for ; Thu, 2 Feb 2017 10:21:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2DC99160B57; Thu, 2 Feb 2017 09:21:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D04E5160B54 for ; Thu, 2 Feb 2017 10:21:01 +0100 (CET) Received: (qmail 67105 invoked by uid 500); 2 Feb 2017 09:21:00 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 67094 invoked by uid 99); 2 Feb 2017 09:20:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 09:20:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 65DABC0258 for ; Thu, 2 Feb 2017 09:20:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id fOmf8kjpazOI for ; Thu, 2 Feb 2017 09:20:58 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id D4F0A5F3A1 for ; Thu, 2 Feb 2017 09:20:56 +0000 (UTC) Received: (qmail 66957 invoked by uid 99); 2 Feb 2017 09:20:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 09:20:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 71C592DAA37; Thu, 2 Feb 2017 09:20:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2597236785458781990==" MIME-Version: 1.0 Subject: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references From: Suma Shivaprasad To: atlas Date: Thu, 02 Feb 2017 09:20:54 -0000 Message-ID: <20170202092054.1722.13968@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56206/ X-Sender: Suma Shivaprasad Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas archived-at: Thu, 02 Feb 2017 09:21:03 -0000 --===============2597236785458781990== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56206/ ----------------------------------------------------------- Review request for atlas. Bugs: ATLAS-1522 https://issues.apache.org/jira/browse/ATLAS-1522 Repository: atlas Description ------- Currently child(composite) entities are allowed as attribute values in create or update APIs. Allowing this to have only AtlasObjectId would avoid cycles in the entity structure Diffs ----- client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 8d1bfa7 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 9494fe4 intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java c9b6e97 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java fcd483c intg/src/test/java/org/apache/atlas/TestUtilsV2.java 0756937 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java 2d748da repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java 2848a20 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1590aee repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java a989f76 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java d02b5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java 76308a0 repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 31a619e webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java bbfcc59 webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 7368c72 webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5107767 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cfe9909 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java ee36fdf Diff: https://reviews.apache.org/r/56206/diff/ Testing ------- Thanks, Suma Shivaprasad --===============2597236785458781990==--