atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Hagelberg (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (ATLAS-1526) update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute
Date Mon, 06 Feb 2017 19:34:42 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854586#comment-15854586
] 

Jeffrey Hagelberg edited comment on ATLAS-1526 at 2/6/17 7:34 PM:
------------------------------------------------------------------

[~madhan.neethiraj] - Just want to make you aware that this logic is causing a regression
in Atlas (as was the logic it replaced).  In the test model hive_table_v1 (created in BaseResourceIT),
the isComposite attribute is now being ignored in the "db" field because there is not a reverse
reference associated with it.  I'm not sure if that was the intention or not -- but this is
definitely a breaking change.  The isComposite attribute does not only affect deletion, it
also affects creation.  With a composite attribute, you can inline referenced entities.  This
allows a whole containment graph to be created with one call.  This is no longer possible
for any composite attributes that do not have an associated reverse reference.  I had fixed
this issue in my changes for https://issues.apache.org/jira/browse/ATLAS-746.  With the latest
changes, though, the fix is no logger applicable.  It might make sense to take a more holistic
view that includes the semantics for both creation and deletion.  Perhaps this could be another
type of constraint, not sure....


was (Author: jnhagelb):
[~madhan.neethiraj] - Just want to make you aware that this logic is causing a regression
in Atlas (as was the logic before it).  In the test model hive_table_v1 (created in BaseResourceIT),
the isComposite attribute is now being ignored in the "db" field because there is not a reverse
reference associated with it.  I'm not sure if that was the intention or not -- but this is
definitely a breaking change.  The isComposite attribute does not only affect deletion, it
also affects creation.  With a composite attribute, you can inline referenced entities.  This
allows a whole containment graph to be created with one call.  This is no longer possible
for any composite attributes that do not have an associated reverse reference.  I had fixed
this issue in my changes for https://issues.apache.org/jira/browse/ATLAS-746.  With the latest
changes, though, the fix is no logger applicable.  It might make sense to take a more holistic
view that includes the semantics for both creation and deletion.  Perhaps this could be another
type of constraint, not sure....

> update AtlasAttribute with methods to derive legacy flags isComposite/reverseAttribute
> --------------------------------------------------------------------------------------
>
>                 Key: ATLAS-1526
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1526
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: 0.8-incubating
>            Reporter: Madhan Neethiraj
>            Assignee: Madhan Neethiraj
>             Fix For: 0.8-incubating
>
>         Attachments: ATLAS-1526.patch, Atlas-legacy-to-new-ModelMapping.pdf
>
>
> The logic to map legacy attribute flags isComposite/reverseAttribute to its equivalent
constraints in the new data model is spread across multiple locations. Consolidating this
logic to a single class will make it easier to manage.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message