atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Hagelberg <jnhagelb...@us.ibm.com>
Subject Re: Review Request 56963: DSL queries returns wrong object when filter traverses edges
Date Thu, 23 Feb 2017 17:16:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56963/
-----------------------------------------------------------

(Updated Feb. 23, 2017, 5:16 p.m.)


Review request for atlas.


Changes
-------

Addressed defect in GremlinQueryOptimizer exposed by these changes.


Bugs: ATLAS-1589
    https://issues.apache.org/jira/browse/ATLAS-1589


Repository: atlas


Description
-------

In Atlas 0.7, the following DSL query returns hive_table entities whose db.name=’default’.
api/atlas/discovery/search/dsl?limit=25&query=hive_table+db.name%3D%27default%27

However, with the latest Atlas in master, the query returns the hive_db entity, instead of
hive_table entities.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 798d9099f8999c98ac14b6060179add76e5a2ff4

  repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java add7e07006190247112eeba1ca85d62b6f5c2a08

  repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java c2fdf092d2078749a0d43d5c55be5d87fd24fc4e

  repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandOrsOptimization.java ba6059a32e9ca2b36dc121ae4d8c209aa567bddc

  repository/src/main/java/org/apache/atlas/gremlin/optimizer/RepeatExpressionFinder.java
PRE-CREATION 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 2863aca1a1bfa7cd200230b314ddb9954266fe87

  repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
ffda9849e9632bff6764aed70c76a2f50f493d0d 

Diff: https://reviews.apache.org/r/56963/diff/


Testing
-------

Ran repository tests, everything passed on Windows except the expected hbase tests.  Running
full test suite on Linux.


Thanks,

Jeff Hagelberg


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message