atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Review Request 56897: ATLAS-1577: audit event generated for an entity overwrites previous audit event for the entity
Date Tue, 21 Feb 2017 19:35:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56897/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1577
    https://issues.apache.org/jira/browse/ATLAS-1577


Repository: atlas


Description
-------

The key for audit log (in HBase) is generated using the entity-guid and the request-time.
With the changes in ATLAS-1499, the request-time used here was not populated - resulting in
earlier audit log be overwritten. Updated to populate request-time to address this issue.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java e4dcfca

  server-api/src/main/java/org/apache/atlas/RequestContext.java d35f456 
  webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 44c7995

  webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java d804f21 

Diff: https://reviews.apache.org/r/56897/diff/


Testing
-------

- Verified that audit logs for an entity don't overwrite the previous log, by performaing
the following in Hive:
 -- create a table
 -- alter the table by adding a column
 -- delete the table


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message