atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Review Request 56815: ATLAS-1568: moved helper methods from org.apache.atlas.model package classes into an utility class
Date Sat, 18 Feb 2017 19:46:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56815/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1568
    https://issues.apache.org/jira/browse/ATLAS-1568


Repository: atlas


Description
-------

Moved the following methods to AtlasTypeUtil class:
- AtlasEntity.getObjectId()
- AtlasEntityHeader.getObjectId()
- AtlasObjectId.isValidGuid(guid)
- AtlasObjectId.isAssignedGuid(guid)
- AtlasObjectId.isUnassignedGuid(guid)


Diffs
-----

  client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java a1aef61 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java e74813a 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 94b3aa6 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java dea3a93 
  intg/src/main/java/org/apache/atlas/model/instance/GuidMapping.java 43ce3b0 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 626f18e 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 0a82f40 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 6d85672 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
436de49 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
8a6501c 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
8c96c7b 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
527ce15 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java
e773f02 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
1ac9bd1 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
c55e3f7 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
7f76236 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 26bf496 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b90627f 
  webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java 04bb4d3 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 2d48770 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 1df9d2f 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 5e57518 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 96e6f9b

  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java 639d581


Diff: https://reviews.apache.org/r/56815/diff/


Testing
-------

verified that unit tests pass successfully


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message