atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david_rad...@uk.ibm.com>
Subject Re: Review Request 56105: ATLAS-1506: updated AtlasObjectId to support unqiueAttributes to identity the object
Date Thu, 16 Feb 2017 13:58:14 GMT


> On Feb. 15, 2017, 11:51 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java, line 53
> > <https://reviews.apache.org/r/56105/diff/1/?file=1619639#file1619639line53>
> >
> >     AtlasObjectId should point to an unique object; hence the use of 'uniqueAttributes'
here. If a non-unique attribute is allowed, it can potentially match muliple objects - making
AtlasObjectId ambigious.

Policing attributes in graphs to be unique is problematic; how do you police uniqueness without
big graph scans. If we label attributes as unique but do not police it - this is misleading
as the attriubutes may not be unique in reality. 
Too many unique attributes would lead to a proliferation of indexes and associated performance
implications. RDBs have slick mechanisms for dealing with primary keys and foreign keys and
the like - they can readily do this as they are set based. This is why I think we should not
be encouraging the use of unique attributes. I think being able to specify any attribute would
help; for example a name is useful but not unique.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56105/#review165780
-----------------------------------------------------------


On Jan. 31, 2017, 1:08 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56105/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 1:08 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1506
>     https://issues.apache.org/jira/browse/ATLAS-1506
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Attribute uniqueAttribues is now added to AtlasObjectId.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 4896e9d 
>   intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java a25f3f6 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 7d55233 
> 
> Diff: https://reviews.apache.org/r/56105/diff/
> 
> 
> Testing
> -------
> 
> - updated unit tests to cover the changes to AtlasObjectId
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message