atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 56651: ATLAS-1554: v2 EntityREST implementation for entity partial update
Date Thu, 16 Feb 2017 00:17:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56651/
-----------------------------------------------------------

(Updated Feb. 15, 2017, 4:17 p.m.)


Review request for atlas.


Changes
-------

* Updated AtlasEntityType methods to skip AtlasObjectId validation.
* Refactored AtlasStructType methods - isValidValueForUpdate(), getNormalizedValueForUpdate()
and validateValueForUpdate()
* Moved ValidateAndNormalize step after discovery and resolveReference stage.


Bugs: ATLAS-1554
    https://issues.apache.org/jira/browse/ATLAS-1554


Repository: atlas


Description
-------

Add REST endpoints to enable partial update of entity using unique attributes and implement
the same.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45b12e3 
  intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 246a0bf 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 318f2ed 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java d997725 
  intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f0d94a9 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 3bc5f83 
  intg/src/main/java/org/apache/atlas/type/AtlasType.java 59d93cf 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 00566a1 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f3e9563

  repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java
a12ba3b 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
256c5f6 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
34c10f4 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
6a1b301 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
b35d288 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
e812ca6 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b4fe3d7 

Diff: https://reviews.apache.org/r/56651/diff/


Testing
-------

mvn clean package - Build succeeded with all tests passed.
mvn clean install - usual failure in webapp module - TaxonomyServiceTest


Thanks,

Sarath Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message