atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 56105: ATLAS-1506: updated AtlasObjectId to support unqiueAttributes to identity the object
Date Wed, 15 Feb 2017 23:51:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56105/#review165780
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java (line 53)
<https://reviews.apache.org/r/56105/#comment237635>

    AtlasObjectId should point to an unique object; hence the use of 'uniqueAttributes' here.
If a non-unique attribute is allowed, it can potentially match muliple objects - making AtlasObjectId
ambigious.



intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java (line 553)
<https://reviews.apache.org/r/56105/#comment237636>

    In general, allowing entity type attributes to have value of entire entity is trouble!
ATLAS-1522 addresses this concern - by restricting such attributes to hold only objectid as
value. Please review this JIRA for details.
    
    With this update, attribute values in AtlasObjectId.uniqueAttributes will only have objectid
value - and not an entire entity.


- Madhan Neethiraj


On Jan. 31, 2017, 1:08 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56105/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 1:08 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1506
>     https://issues.apache.org/jira/browse/ATLAS-1506
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Attribute uniqueAttribues is now added to AtlasObjectId.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 4896e9d 
>   intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java a25f3f6 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 7d55233 
> 
> Diff: https://reviews.apache.org/r/56105/diff/
> 
> 
> Testing
> -------
> 
> - updated unit tests to cover the changes to AtlasObjectId
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message