atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 56535: Add tests for DeleteHandlerV1
Date Tue, 14 Feb 2017 06:39:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165461
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 393)
<https://reviews.apache.org/r/56535/#comment237303>

    lines #393, 394, 398 should be deleted.



intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 96)
<https://reviews.apache.org/r/56535/#comment237304>

    inverseRef constraint should be on Employee.department attribute, right? Not on Department.employees.
    
    Department.employees attribute can't have both ownedRef and inverseRef constraint.



intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 149)
<https://reviews.apache.org/r/56535/#comment237305>

    inverseRef constraint on Manager.subordinates does not look right. If mappedFromRef was
supported, that would have been the right constraint here.



intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 188)
<https://reviews.apache.org/r/56535/#comment237306>

    Same as earlier comment for DEPARTMENT_TYPE entityDef:
    inverseRef constraint should be on Employee.department attribute. Please review.



intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 240)
<https://reviews.apache.org/r/56535/#comment237307>

    inverseRef is same as 'reverseAttribute' in earlier version. This constraint does not
look right no Manager.subordinates.


- Madhan Neethiraj


On Feb. 14, 2017, 5:33 a.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 5:33 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1547
>     https://issues.apache.org/jira/browse/ATLAS-1547
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added UTs for delete operations
> 
> 
> Diffs
> -----
> 
>   addons/models/0030-hive_model.json 33ba156 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cbc91f5

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
1f4ad57 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
ff13ea5 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
cb8636b 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
fe0db39 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
7e3068b 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
9d01357 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java
PRE-CREATION 
>   server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce 
> 
> Diff: https://reviews.apache.org/r/56535/diff/
> 
> 
> Testing
> -------
> 
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message