atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update
Date Mon, 13 Feb 2017 23:19:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56585/#review165401
-----------------------------------------------------------


Ship it!




Ship It!

- Suma Shivaprasad


On Feb. 13, 2017, 11:07 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56585/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 11:07 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1544
>     https://issues.apache.org/jira/browse/ATLAS-1544
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - AtlasEntityStoreV1 implementation updated to use EntityGraphMapper (instead of StructVertexMapper,
MapVertexMapper, ArrayVertexMapper classes)
> - refactored EntityGraphDiscoveryContext and related classes (IDBasedResolver, UniqAttributeBasedResolver)
> - updated unit tests TestEntityREST and TestEntitiesREST; addressed the issues caught
by these unit tests
> - AtlasObjectId updated to require typeName only when GUID is not specified. Updated
its constructors to make this intutive
> - changes in discovery and resolver implementation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8214095 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
7141911 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
06ceaf2 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
21a3af1 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 948583f 
> 
> Diff: https://reviews.apache.org/r/56585/diff/
> 
> 
> Testing
> -------
> 
> all unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message