atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 47658: ATLAS-499: Update reverse references
Date Fri, 10 Feb 2017 19:50:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47658/#review165156
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
(line 748)
<https://reviews.apache.org/r/47658/#comment236966>

    Isn't there a need for "removeReverseReference()" - to update the reverseAttribute when
a referred entity is deleted? For example: when a hive_column entity is deleted, hive_table.columns
needs to be updated.
    
    Perhaps this is already handled in the current implementation. If so, please ignore this
comment.


- Madhan Neethiraj


On June 17, 2016, 2:44 a.m., David Kantor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47658/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 2:44 a.m.)
> 
> 
> Review request for atlas and Shwetha GS.
> 
> 
> Bugs: ATLAS-499
>     https://issues.apache.org/jira/browse/ATLAS-499
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-499: Automatically update inverse references to prevent repository corruption from
unbalanced references.
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14 
>   addons/hive-bridge/src/test/resources/je.properties PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 91f9bd008a6939dfe78656f5c1845637a30ee9eb

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 4f6d0118072380342f5ea302d0aaf7902784849a

>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
4c1f5591f4adead41c3336e64b0bc956836f7edb 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
449e066a167ba4546b118a77c8e3de5fd99f077b 
>   repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java
PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java
PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47658/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit and integration tests with no regressions.
> 
> 
> Thanks,
> 
> David Kantor
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message