atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef constraints and brought back legacy flags isComposite/reverseAttributeName using constraints owner/inverseRef(attribute=attr1)
Date Thu, 09 Feb 2017 04:00:14 GMT


> On Feb. 8, 2017, 12:42 a.m., Jeff Hagelberg wrote:
> > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, line 480
> > <https://reviews.apache.org/r/56380/diff/2/?file=1626955#file1626955line480>
> >
> >     It looks like this these comments are now obsolete.

Good catch Jeff. I will update these comments in my next patch.


> On Feb. 8, 2017, 12:42 a.m., Jeff Hagelberg wrote:
> > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, line 479
> > <https://reviews.apache.org/r/56380/diff/2/?file=1626955#file1626955line479>
> >
> >     Should this be an enumeration?  I think that Jackson supports enumerations.

Enum would be a good idea. I will verify Jackson handling of enums and update in a separate
patch.


> On Feb. 8, 2017, 12:42 a.m., Jeff Hagelberg wrote:
> > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, line 473
> > <https://reviews.apache.org/r/56380/diff/2/?file=1626955#file1626955line473>
> >
> >     Could you add javadoc to document what these are and the semantics associated
with them?

I think adding these details in twiki, along with new REST API details, might be a good option.
I am working on this; should be done sometime next week.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164598
-----------------------------------------------------------


On Feb. 7, 2017, 10:55 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 10:55 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1526
>     https://issues.apache.org/jira/browse/ATLAS-1526
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of
legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints
"owner" and "inverserRef(attribute=attr)"
> 
> 
> Diffs
> -----
> 
>   addons/models/0030-hive_model.json 5ae16cf 
>   addons/models/0060-hbase_model.json 5febbbc 
>   addons/models/0080-storm_model.json 344227d 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
69cf60a 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
f507ae0 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java
2e9e5e4 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d8202a5 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 9d4b04e 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
4158f01 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6187cfb 
> 
> Diff: https://reviews.apache.org/r/56380/diff/
> 
> 
> Testing
> -------
> 
> updated unit tests and verified that existing unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message