atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Hagelberg <jnhagelb...@us.ibm.com>
Subject Re: Review Request 56289: Atlas-695: Add Titan1 suport in Atlas.
Date Thu, 09 Feb 2017 03:00:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56289/#review164799
-----------------------------------------------------------



Let's discuss this tomorrow.


graphdb/titan1/pom.xml (line 36)
<https://reviews.apache.org/r/56289/#comment236595>

    Please remove this line -- the titan1 project has 886 checkstyle violations.



graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
(line 54)
<https://reviews.apache.org/r/56289/#comment236596>

    There are unit test failures in this class that need to be fixed:
    
    Failed tests:
      GraphQueryTest>AbstractGraphDatabaseTest.createIndices:57 ? ClassCast com.thin...
      Titan1DatabaseTest.cleanup:79 NullPointer
      Titan1DatabaseTest.getGetGraphQueryForVertices:347->getGraph:61 ? ClassCast co...
      Titan1DatabaseTest.testAddMultManyPropertyValueTwice:399->getGraph:61 ? ClassCast
      Titan1DatabaseTest.testGetEdges:221->getGraph:61 ? ClassCast com.thinkaurelius...
      Titan1DatabaseTest.testListProperties:296->getGraph:61 ? ClassCast com.thinkau...
      Titan1DatabaseTest.testMultiplicityOnePropertySupport:149->getGraph:61 ? ClassCast
      Titan1DatabaseTest.testMultiplictyManyPropertySupport:257->getGraph:61 ? ClassCast
      Titan1DatabaseTest.testPropertyDataTypes:88->getGraph:61 ? ClassCast com.think...
      Titan1DatabaseTest.testRemoveEdge:185->getGraph:61 ? ClassCast com.thinkaureli...
      Titan1DatabaseTest.testRemoveProperty:319->getGraph:61 ? ClassCast com.thinkau...
      Titan1DatabaseTest.testRemoveVertex:207->getGraph:61 ? ClassCast com.thinkaure...



graphdb/graphdb-impls/pom.xml (line 36)
<https://reviews.apache.org/r/56289/#comment236603>

    There should be no profiles in this file.  See graphdb\graphdb-impls\pom.xml in the fork.
 The idea is that all of the implementations are declared as dependencies here, in the root
pom.xml the implementations not being used are excluded based on the maven profile selected.



graphdb/pom.xml (line 52)
<https://reviews.apache.org/r/56289/#comment236584>

    fix indentation



graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java
(line 175)
<https://reviews.apache.org/r/56289/#comment236598>

    This is logic is wrong -- that is what is causing the unit test failures.  It should something
like:
        
        @Override
        public AtlasGraph<Titan1Vertex, Titan1Edge> getGraph() {
            //trigger loading of Titan1 graph on demand
            getGraphInstance();
            atlasGraphInstance;
        }
        Generally, the Titan1GraphDatabase class should have the same basic logic that is
in Titan0GraphDatabase, but using the Titan1 classes.  There should be a single instance of
Titan1Graph that is created in Titan1GraphDatabase.getGraphInstance()


- Jeff Hagelberg


On Feb. 8, 2017, 8:34 p.m., Neeru Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56289/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 8:34 p.m.)
> 
> 
> Review request for atlas, David Kantor and Jeff Hagelberg.
> 
> 
> Bugs: ATLAS-695
>     https://issues.apache.org/jira/browse/ATLAS-695
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-695 Add titan1 project in atlas
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml 00e56dc6d01959f81a2d0884396837e261cb3ff0 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 6a2ba53ddfc740bf77baf319b458853bd33864ec

>   catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 901a549a8945d7314373feac8b9a5fea1340a85d

>   graphdb/graphdb-impls/pom.xml 57b5137178dd179f86edb9a7af4f260b4b7d0ece 
>   graphdb/pom.xml 2d303e4d5c29943ceef7883f3ad10a366d7f26aa 
>   graphdb/titan0/pom.xml 9d88a72f60a3fa6969a94bf62f40d0192781c199 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
f1b38e1a801c37d07857df77c48a2fadf8fee62b 
>   graphdb/titan0/src/main/java/org/apache/atlas/utils/IteratorToIterableAdapter.java
ed7c2a71ed1f12470a0a19e475adb145282c1681 
>   graphdb/titan1/pom.xml PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java
PRE-CREATION 
>   graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java
PRE-CREATION 
>   graphdb/titan1/src/test/resources/atlas-application.properties PRE-CREATION 
>   pom.xml 834ecae05ac73b2c42b61d2b4115f052a3c45ea8 
>   webapp/pom.xml 5dc74019810cf8cd5b59d256e69f602c561119a0 
> 
> Diff: https://reviews.apache.org/r/56289/diff/
> 
> 
> Testing
> -------
> 
> This review request contains titan 1 project and related changes. Titan 1 project is
disabled by default. It gets enabled when titan1 profile is enabled. It requires Java 8.
> 
> More changes may require to bring Atlas up with Titan1. This serves as initial implementation
to support Titan1.
> 
> It was a team effort at IBM. Jeff Hagelberg has contributed in this project.
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message