atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 56260: [ATLAS-1523] Implement GET entity by guid and unique attributes in V2 Entity API using AtlasObjectID
Date Mon, 06 Feb 2017 07:15:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/
-----------------------------------------------------------

(Updated Feb. 5, 2017, 11:15 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.


Changes
-------

* addressed review comments


Bugs: ATLAS-1523
    https://issues.apache.org/jira/browse/ATLAS-1523


Repository: atlas


Description
-------

Current implementation of GET API for entity v2 still routes to V1 entity APIs and does a
V1toV2 conversion. We need to directly query the v2 entitiesStore to get the required entity.


Diffs (updated)
-----

  addons/models/0030-hive_model.json 561cf5b 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 9494fe4 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java c42f95f

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
4c79cef 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
546cd0c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9 

Diff: https://reviews.apache.org/r/56260/diff/


Testing
-------

Tested using POSTMAN


Thanks,

Sarath Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message