Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 04878200C01 for ; Thu, 19 Jan 2017 23:13:14 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 032DD160B54; Thu, 19 Jan 2017 22:13:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 250D0160B3A for ; Thu, 19 Jan 2017 23:13:12 +0100 (CET) Received: (qmail 54926 invoked by uid 500); 19 Jan 2017 22:13:12 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 54914 invoked by uid 99); 19 Jan 2017 22:13:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2017 22:13:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A2EB9C0311 for ; Thu, 19 Jan 2017 22:13:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.317 X-Spam-Level: X-Spam-Status: No, score=-3.317 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ws60SyMPmnaZ for ; Thu, 19 Jan 2017 22:13:10 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id CFE975FB1E for ; Thu, 19 Jan 2017 22:13:08 +0000 (UTC) Received: (qmail 54883 invoked by uid 99); 19 Jan 2017 22:13:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2017 22:13:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EED42315C0A; Thu, 19 Jan 2017 22:13:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7148154015789796756==" MIME-Version: 1.0 Subject: Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation From: Suma Shivaprasad To: Madhan Neethiraj , Apoorv Naik , atlas Date: Thu, 19 Jan 2017 22:13:06 -0000 Message-ID: <20170119221306.28414.75650@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55531/ X-Sender: Suma Shivaprasad References: <20170119220832.28414.54942@reviews.apache.org> In-Reply-To: <20170119220832.28414.54942@reviews.apache.org> X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/ArrayVertexMapper.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/EntityResolver.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/InstanceGraphMapper.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphMutationContext.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/MapVertexMapper.java X-ReviewBoard-Diff-For: server-api/src/main/java/org/apache/atlas/RequestContextV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas archived-at: Thu, 19 Jan 2017 22:13:14 -0000 --===============7148154015789796756== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55531/ ----------------------------------------------------------- (Updated Jan. 19, 2017, 10:13 p.m.) Review request for atlas. Changes ------- Fixed review comment in AtlasClassificationType Bugs: ATLAS-1467 https://issues.apache.org/jira/browse/ATLAS-1467 Repository: atlas Description ------- Implemented 1. Entity graph discovery - This differs from current implementation in that it collects all references first and resolves them later . The current implemenation tries to resolve references at the same time resulting in issues when entities have cross references to each other . Also it handles resolving a refernce by its unique attribute (by supplying an AtlasEntity instead of an Id) 2. Create with new APIs and POJOs ( no change in graph model ) 3. Full Update with new APIs and POJOs ( no change in graph model ) Diffs (updated) ----- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a6438ed intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 2ad0f76 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java e7b70aa intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 3501c90 intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java aee26ef intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 8772720 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 3625f72 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e20af76 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 53b109c intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java 9429c07 repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 54dda50 repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 2be9a2d repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 45e2dd2 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 5259249 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java f17b816 repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/EntityResolver.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/ArrayVertexMapper.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java e731c11 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java fccbeba repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 18b3b85 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java e780dc1 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphMutationContext.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/InstanceGraphMapper.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/MapVertexMapper.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java PRE-CREATION repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java ea0e670 repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java b1dac9d repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java c7c3286 repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java PRE-CREATION server-api/src/main/java/org/apache/atlas/RequestContextV1.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java c4be236 webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java ad16be7 webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 3565ab3 webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java f6acd07 webapp/src/main/java/org/apache/atlas/web/util/LineageUtils.java 54ca236 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 265b650 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2a75773 webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 44d8a11 webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java 2ade5b0 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java d7702e2 Diff: https://reviews.apache.org/r/55531/diff/ Testing ------- UTs for create TODO: Update testing pending Error handling for unresolved references UTS for discovery Thanks, Suma Shivaprasad --===============7148154015789796756==--