Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 53BED200C00 for ; Wed, 18 Jan 2017 15:55:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5250B160B3A; Wed, 18 Jan 2017 14:55:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9B14E160B34 for ; Wed, 18 Jan 2017 15:55:07 +0100 (CET) Received: (qmail 81907 invoked by uid 500); 18 Jan 2017 14:55:06 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 81896 invoked by uid 99); 18 Jan 2017 14:55:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 14:55:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 07A85C00B6 for ; Wed, 18 Jan 2017 14:55:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.018 X-Spam-Level: X-Spam-Status: No, score=-5.018 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Jl37ci8N5kqk for ; Wed, 18 Jan 2017 14:55:04 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 40ED85F576 for ; Wed, 18 Jan 2017 14:55:04 +0000 (UTC) Received: (qmail 81402 invoked by uid 99); 18 Jan 2017 14:54:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 14:54:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0DD5A3152E9; Wed, 18 Jan 2017 14:54:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7859024956355371205==" MIME-Version: 1.0 Subject: Re: Review Request 55655: IX: Functional Export From: David Radley To: Madhan Neethiraj Cc: David Radley , Ashutosh Mestry , atlas Date: Wed, 18 Jan 2017 14:54:45 -0000 Message-ID: <20170118145445.28415.69032@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David Radley X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55655/ X-Sender: David Radley References: <20170118005900.28415.19519@reviews.apache.org> In-Reply-To: <20170118005900.28415.19519@reviews.apache.org> X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/service/ImportExportTest.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/ix/AtlasIXItem.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/ix/AtlasExportData.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/ix/AtlasExportResult.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/ix/AtlasImportParams.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/rest/ImportExportService.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/ix/AtlasExportParams.java X-ReviewBoard-Diff-For: server-api/src/main/java/org/apache/atlas/services/IImportExportService.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/ix/AtlasImportResult.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/rest/ImportExportREST.java Reply-To: David Radley X-ReviewRequest-Repository: atlas archived-at: Wed, 18 Jan 2017 14:55:08 -0000 --===============7859024956355371205== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55655/#review162106 ----------------------------------------------------------- webapp/src/main/java/org/apache/atlas/web/rest/ImportExportREST.java (line 57) Please remove this method. - David Radley On Jan. 18, 2017, 12:58 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55655/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 12:58 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > Includes: > - Export: > - Specify multiple IX items > - Supported formats: > - Json > - Json file > - Zip file. > - Using Atlas classes. > - Updated AtlasExportResult > > Pending: > - Lineage data. > - Audit data. > > > Diffs > ----- > > .gitignore cf2ef74 > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 9f33115 > intg/src/main/java/org/apache/atlas/model/ix/AtlasExportData.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/ix/AtlasExportParams.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/ix/AtlasExportResult.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/ix/AtlasIXItem.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/ix/AtlasImportParams.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/ix/AtlasImportResult.java PRE-CREATION > repository/src/test/java/org/apache/atlas/service/ImportExportTest.java PRE-CREATION > server-api/src/main/java/org/apache/atlas/services/IImportExportService.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/ImportExportREST.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/ImportExportService.java PRE-CREATION > > Diff: https://reviews.apache.org/r/55655/diff/ > > > Testing > ------- > > - Verified with hive_db creation. > - Verified with database created from QuickStart script. > - File format creation. > > Pending: > - Import testing. > > > File Attachments > ---------------- > > Sample JSON Output > https://reviews.apache.org/media/uploaded/files/2017/01/18/c741aea9-7129-4f8f-a9b7-a3c276d03b89__AtlasExportResult.json > Sample POST Input > https://reviews.apache.org/media/uploaded/files/2017/01/18/573a278b-0634-4545-a0e9-e3480fed5e0a__sample-input.sh > > > Thanks, > > Ashutosh Mestry > > --===============7859024956355371205==--