Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============5273314330968840248=="
MIME-Version: 1.0
Subject: Re: Review Request 55592: [ATLAS-1463] Mechanism to exclude specified
 entity
 attributes from getting stored in audit repository during entity
 create/update/delete operations
From: Madhan Neethiraj <madhan@apache.org>
To: Apoorv Naik <naik.apoorv@gmail.com>, Madhan Neethiraj <madhan@apache.org>,
 Ashutosh Mestry <amestry@hortonworks.com>
Cc: Sarath Subramanian <sarath.kum4r@gmail.com>,
 atlas <dev@atlas.incubator.apache.org>
Date: Tue, 17 Jan 2017 04:18:06 -0000
Message-ID: <20170117041806.28415.96297@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Madhan Neethiraj <noreply@reviews.apache.org>
References: <20170116222124.28415.3055@reviews.apache.org>
In-Reply-To: <20170116222124.28415.3055@reviews.apache.org>
Reply-To: Madhan Neethiraj <madhan@apache.org>
archived-at: Tue, 17 Jan 2017 04:18:13 -0000

--===============5273314330968840248==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55592/#review161815
-----------------------------------------------------------


repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java (line 299)
<https://reviews.apache.org/r/55592/#comment233120>

    With addition of repositoryMaxSiz() in each repository implementation, this method may not be needed.
    
    Also, consider moving getAuditExcludeAttributes() to specific repository implementation.
    
    Please review.


- Madhan Neethiraj


On Jan. 16, 2017, 10:21 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55592/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 10:21 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1463
>     https://issues.apache.org/jira/browse/ATLAS-1463
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas uses HBase as its store for audit repository and when new entities are created the entity definition string along with all its attributes are stored in audit repository. When size of the entity is greater than "hbase.client.keyvalue.maxsize" property then entity creation fails with "KeyValue size too large" exception.
> A property needs to be set in atlas-application.properties to specify list of attributes to be excluded from getting stored in audit repo. Also check needs to be made to make sure entity size is not greater than keyvalue max size.
> 
> This patch excludes specified attribute from getting stored in audit repository and also does a size check for max allowed entity size to be stored in the audit repo.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 958ecaf 
>   repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java 417092a 
>   repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 5099521 
>   repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java cf76596 
>   repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java 9f77bfe 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 9a9beff 
> 
> Diff: https://reviews.apache.org/r/55592/diff/
> 
> 
> Testing
> -------
> 
> Tested using POSTMAN REST Client. Created large entities and made sure entities created fine.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


--===============5273314330968840248==--