Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 561E5200BF3 for ; Thu, 5 Jan 2017 15:19:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 54A4D160B27; Thu, 5 Jan 2017 14:19:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 98C49160B26 for ; Thu, 5 Jan 2017 15:19:58 +0100 (CET) Received: (qmail 16483 invoked by uid 500); 5 Jan 2017 14:19:57 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 16472 invoked by uid 99); 5 Jan 2017 14:19:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2017 14:19:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1E4F91A0363 for ; Thu, 5 Jan 2017 14:19:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.768 X-Spam-Level: X-Spam-Status: No, score=-4.768 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id oxdX5SQlf4Z8 for ; Thu, 5 Jan 2017 14:19:55 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 887075F1B8 for ; Thu, 5 Jan 2017 14:19:54 +0000 (UTC) Received: (qmail 16455 invoked by uid 99); 5 Jan 2017 14:19:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2017 14:19:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 03DDA3112EE; Thu, 5 Jan 2017 14:19:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6720664050350007195==" MIME-Version: 1.0 Subject: Re: Review Request 54759: ATLAS-1379 Avoid object query overhead when report query selects class type alias From: David Kantor To: David Kantor Cc: atlas , Neeru Gupta Date: Thu, 05 Jan 2017 14:19:53 -0000 Message-ID: <20170105141953.13478.90835@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David Kantor X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54759/ X-Sender: David Kantor X-ReviewBoard-ShipIt: 1 References: <20170103202140.13569.23540@reviews.apache.org> In-Reply-To: <20170103202140.13569.23540@reviews.apache.org> Reply-To: David Kantor X-ReviewRequest-Repository: atlas archived-at: Thu, 05 Jan 2017 14:19:59 -0000 --===============6720664050350007195== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54759/#review160585 ----------------------------------------------------------- Ship it! Hi Neeru, I've committed these changes and resolved ATLAS-1379. Please close this review request as submitted. Thanks... - David Kantor On Jan. 3, 2017, 8:21 p.m., Neeru Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54759/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 8:21 p.m.) > > > Review request for atlas and David Kantor. > > > Bugs: ATLAS-1379 > https://issues.apache.org/jira/browse/ATLAS-1379 > > > Repository: atlas > > > Description > ------- > > OMS-743 when an object instance is selected in select query then only fetch the id (guid, typename, version and state) for performance reasons > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fb027efc1ad9a7b2c562fc6670a8f9647b3b54f0 > repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java aad056f5247cd5ac0e5c84d2f1fa9c4bb5458fb3 > repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java f2a1fe975bc720e3003389806f1e32d3edf74713 > repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java a2a9ab6dafcefaa29110051c35d3b6762017a28f > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 51e9ab1fb6bfe7e854bcf40bfc3d92136de4c60f > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 2c12bc3e82109819759c3c54ba3a786fee656594 > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java f6b3fc5ffb6dd76271ccf8217b587b52b98cf78b > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7eacc5dbf186885a3e51294b8717bc9c05bd0b66 > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 19ca328a7f4240ea62fdd171f23c6c5c14d25af5 > repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala eb6d119b2eca699d67fe071fe2659de2fddb9285 > repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 9e336cf2abb90141a16220cae078952cdc410475 > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java aaa8fa0d594e97fabfa51c5c76c5aab879bf8e7f > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java d73a7b32add5d9e4eb24afefed042cf894964992 > > Diff: https://reviews.apache.org/r/54759/diff/ > > > Testing > ------- > > All Unit tests executed successfully. > > Added new test cases in GraphBackedDiscoveryTest to valiadte the fields coming back with id type report queries. > > > Thanks, > > Neeru Gupta > > --===============6720664050350007195==--