Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0DC73200BF1 for ; Tue, 3 Jan 2017 17:57:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0C66D160B43; Tue, 3 Jan 2017 16:57:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 54FC4160B20 for ; Tue, 3 Jan 2017 17:57:52 +0100 (CET) Received: (qmail 33598 invoked by uid 500); 3 Jan 2017 16:57:51 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 33583 invoked by uid 99); 3 Jan 2017 16:57:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 16:57:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B069218C4C2 for ; Tue, 3 Jan 2017 16:57:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.019 X-Spam-Level: X-Spam-Status: No, score=-5.019 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3nXvuJPeQ7uo for ; Tue, 3 Jan 2017 16:57:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 8495A5F295 for ; Tue, 3 Jan 2017 16:57:48 +0000 (UTC) Received: (qmail 33524 invoked by uid 99); 3 Jan 2017 16:57:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 16:57:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EFA8130EE42; Tue, 3 Jan 2017 16:57:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7009125570484462835==" MIME-Version: 1.0 Subject: Re: Review Request 55138: ATLAS-1424 - Avoid stack-trace in REST API error response From: Madhan Neethiraj To: Vimal Sharma , keval bhatt , Madhan Neethiraj Cc: atlas , David Radley , Nixon Rodrigues Date: Tue, 03 Jan 2017 16:57:46 -0000 Message-ID: <20170103165746.13478.53580@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55138/ X-Sender: Madhan Neethiraj References: <20170103160844.13478.55217@reviews.apache.org> In-Reply-To: <20170103160844.13478.55217@reviews.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas archived-at: Tue, 03 Jan 2017 16:57:53 -0000 --===============7009125570484462835== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 3, 2017, 4:08 p.m., David Radley wrote: > > Hi, Can you confirm that after fix, the stack trace for this exception will be logged - even if it is not sent back in the REST response. The fix only removes the stack trace from HTTP response. I confirmed that the error log generated continues to include the stack trace. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55138/#review160391 ----------------------------------------------------------- On Jan. 3, 2017, 2:23 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55138/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 2:23 p.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, and Vimal Sharma. > > > Bugs: ATLAS-1424 > https://issues.apache.org/jira/browse/ATLAS-1424 > > > Repository: atlas > > > Description > ------- > > This patch provides fix to avoid stack-trace in REST API error response, by removing stacktrace attribute from json response. > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/util/Servlets.java b4f0839 > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 23203ec > > Diff: https://reviews.apache.org/r/55138/diff/ > > > Testing > ------- > > Execute test cases using mvn clean install > > Tested json response for discovery, types, entity type of api's in normal & exceptional conditions. > > > Thanks, > > Nixon Rodrigues > > --===============7009125570484462835==--