atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey N Hagelberg" <jnhagelb...@us.ibm.com>
Subject RE: Review Request 55443: ATLAS-1387 : Compiled Query Cache
Date Tue, 31 Jan 2017 15:06:24 GMT
Ok, thanks!

 

From: Madhan Neethiraj [mailto:madhan@apache.org] 
Sent: Monday, January 30, 2017 10:55 PM
To: Jeffrey N Hagelberg <jnhagelberg@us.ibm.com>; Fnu Neerju <guptaneeru@us.ibm.com>;
Dave Kantor <dkantor@us.ibm.com>
Cc: Sarath Subramanian <sarath.kum4r@gmail.com>; Madhan Neethiraj <madhan@apache.org>;
atlas <dev@atlas.incubator.apache.org>; Vimal Sharma <visharma@hortonworks.com>
Subject: Re: Review Request 55443: ATLAS-1387 : Compiled Query Cache

 

Jeff – I am about to commit the fix for unit test failure (introduced in my earlier commit);
I will update CompiledQueryCacheKeyTest.java with the license header text.

 

Sarath – thanks for investigating at the unit test failure and the fix!

 

Thanks,

Madhan

 

 

From: Jeff Hagelberg <noreply@reviews.apache.org <mailto:noreply@reviews.apache.org>
> on behalf of Jeff Hagelberg <jnhagelberg@us.ibm.com <mailto:jnhagelberg@us.ibm.com>
>
Reply-To: Jeff Hagelberg <jnhagelberg@us.ibm.com <mailto:jnhagelberg@us.ibm.com>
>
Date: Monday, January 30, 2017 at 2:29 PM
To: Neeru Gupta <guptaneeru@us.ibm.com <mailto:guptaneeru@us.ibm.com> >, David
Kantor <dkantor@us.ibm.com <mailto:dkantor@us.ibm.com> >
Cc: Sarath Subramanian <sarath.kum4r@gmail.com <mailto:sarath.kum4r@gmail.com> >,
Jeff Hagelberg <jnhagelberg@us.ibm.com <mailto:jnhagelberg@us.ibm.com> >, Madhan
Neethiraj <madhan@apache.org <mailto:madhan@apache.org> >, atlas <dev@atlas.incubator.apache.org
<mailto:dev@atlas.incubator.apache.org> >, Vimal Sharma <visharma@hortonworks.com
<mailto:visharma@hortonworks.com> >
Subject: Re: Review Request 55443: ATLAS-1387 : Compiled Query Cache

 


This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55443/


 

On January 30th, 2017, 7:03 p.m. UTC, Sarath Subramanian wrote:


 <https://reviews.apache.org/r/55443/diff/10/?file=1618378#file1618378line1> repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java
(Diff revision 10) 

		
1

package org.apache.atlas.util;

Could you add Apache license header here to avoid rat failures.

Unfortunately, this was already committed.  I'm working on putting together a patch for ATLAS-1388.
 I'll fix the RAT issue in there.  I'm expecting to be submitting that for review very soon.

 

- Jeff

 

On January 29th, 2017, 12:18 a.m. UTC, Jeff Hagelberg wrote:


Review request for atlas, David Kantor and Neeru Gupta.

By Jeff Hagelberg.

Updated Jan. 29, 2017, 12:18 a.m.

Bugs: ATLAS-1387 <https://issues.apache.org/jira/browse/ATLAS-1387>  

Repository: atlas 


Description 


Adds a compiled query cache to Atlas.  This avoids the overhead of parsing and translating
DSL queries that have been previously executed.


Testing 


Ran all atlas tests, no regressions found.  There were some tests that failed both with and
without these changes.


Diffs 


*	common/pom.xml (0226541b2dd73e8a01f050982cb8b37f5fed9cab) 
*	common/src/main/java/org/apache/atlas/utils/LruCache.java (PRE-CREATION) 
*	common/src/test/java/org/apache/atlas/utils/LruCacheTest.java (PRE-CREATION) 
*	distro/src/conf/atlas-application.properties (303ce7b00c93f2499e7b18c5f3a131b50c150b69)

*	repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
(fb488cdfc7cef195ffc5221afb9a9109a6e92fc9) 
*	repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java (6655085ee11c94addca1564cf77bbdb001c4586f)

*	repository/src/main/java/org/apache/atlas/util/CompiledQueryCacheKey.java (PRE-CREATION)

*	repository/src/main/java/org/apache/atlas/util/NoopGremlinQuery.java (PRE-CREATION) 
*	repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala (5693c9ecc1a96154a8b0ac48256e5074dc041c5f)

*	repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java (PRE-CREATION)


View Diff <https://reviews.apache.org/r/55443/diff/> 

 



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message