atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-1471) Avoid unnecessary overhead in debug log calls
Date Wed, 18 Jan 2017 22:30:27 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828885#comment-15828885
] 

Madhan Neethiraj commented on ATLAS-1471:
-----------------------------------------

[~svimal2106] - thanks for reviewing the updates to repository module. Committed to master:
http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/34d235f3

Updates to other modules will follow.

> Avoid unnecessary overhead in debug log calls
> ---------------------------------------------
>
>                 Key: ATLAS-1471
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1471
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: 0.7-incubating
>            Reporter: Madhan Neethiraj
>            Assignee: Madhan Neethiraj
>             Fix For: 0.8-incubating
>
>         Attachments: ATLAS-1471.patch
>
>
> Many calls to LOG.debug() pass arguments that are returned from method calls. Many of
these method calls perform non-trivial operations (like GraphHelper.string(), ReferenceableInstance.toShortString(),
.. to name a few).
> Such overheads can be avoided simply by surronding LOG.debug() calls with "if (LOG.isDebugEnabled()".
This can help improve performance, especially in debug calls made in heavily used/low-level
methods - like GraphHelper.getProperty(), GraphHelper.getSingleValuedProperty(), 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message