atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Hagelberg <jnhagelb...@us.ibm.com>
Subject Re: Review Request 56126: ATLAS-1510: Consolidate/batch calls to GraphBackedTypeStore.findVertex()
Date Tue, 31 Jan 2017 20:22:54 GMT


> On Jan. 31, 2017, 4:55 p.m., Apoorv Naik wrote:
> > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java,
line 29
> > <https://reviews.apache.org/r/56126/diff/1/?file=1620107#file1620107line29>
> >
> >     Any particular reason behind the trailing _ ?

That's a naming convention I got used to that indicates that it's a field rather than a local
variable.  I'll remove it.


> On Jan. 31, 2017, 4:55 p.m., Apoorv Naik wrote:
> > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java,
line 75
> > <https://reviews.apache.org/r/56126/diff/1/?file=1620107#file1620107line75>
> >
> >     Objects.equals instead of this.

I've removed the generated equals method and implemented equals to use Objects.equals().


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56126/#review163671
-----------------------------------------------------------


On Jan. 31, 2017, 8:22 p.m., Jeff Hagelberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56126/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 8:22 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Bugs: ATLAS-1510
>     https://issues.apache.org/jira/browse/ATLAS-1510
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> These changes optimize GraphBackedTypeStore.store() so that it does all of the required
vertex lookup up front, using one query.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ce8d4c75610a1337d72134bf245c72e375ad4984

>   repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
c1c2a94e4367d4c4963a6d2807b1fe1d818102f7 
>   repository/src/main/java/org/apache/atlas/repository/typestore/TypePersistenceVisitor.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexFinder.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/typestore/TypeVisitor.java PRE-CREATION

>   repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
6b83aa3222c15ebad92399a6668ee5a802b10802 
> 
> Diff: https://reviews.apache.org/r/56126/diff/
> 
> 
> Testing
> -------
> 
> Ran entire Atlas build, no regressions found.
> 
> 
> Thanks,
> 
> Jeff Hagelberg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message