atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Hagelberg <jnhagelb...@us.ibm.com>
Subject Re: Review Request 55443: ATLAS-1387 : Compiled Query Cache
Date Thu, 26 Jan 2017 15:20:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55443/
-----------------------------------------------------------

(Updated Jan. 26, 2017, 3:20 p.m.)


Review request for atlas, David Kantor and Neeru Gupta.


Changes
-------

Rebased changes.


Bugs: ATLAS-1387
    https://issues.apache.org/jira/browse/ATLAS-1387


Repository: atlas


Description
-------

Adds a compiled query cache to Atlas.  This avoids the overhead of parsing and translating
DSL queries that have been previously executed.


Diffs (updated)
-----

  common/pom.xml 0226541b2dd73e8a01f050982cb8b37f5fed9cab 
  common/src/main/java/org/apache/atlas/utils/LruCache.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/utils/LruMap.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/utils/LruMapEntryUsageTracker.java PRE-CREATION 
  common/src/test/java/org/apache/atlas/utils/LruCacheTest.java PRE-CREATION 
  common/src/test/java/org/apache/atlas/utils/LruMapEntryUsageTrackerTest.java PRE-CREATION

  dashboardv2/public/css/scss/main.scss 1d10bab3aefa7a2984d8f309807fb7e6c29c77c1 
  dashboardv2/public/css/scss/override.scss b0f5c7f9abb79ab760958bf3341a4533f7cfd59f 
  dashboardv2/public/index.html 36ddef5d8f52ab5b48844834bf1db8c410a4c01d 
  dashboardv2/public/js/collection/VSearchList.js 2ec49526d4eae3e723ca6f8e4eed0c5a5ab77de5

  dashboardv2/public/js/external_lib/pnotify.custom.min.js 9c5f67edc4789ffbcc4d21bef2290471a7aada42

  dashboardv2/public/js/external_lib/pnotify/pnotify.buttons.js PRE-CREATION 
  dashboardv2/public/js/external_lib/pnotify/pnotify.confirm.js PRE-CREATION 
  dashboardv2/public/js/external_lib/pnotify/pnotify.custom.min.css  
  dashboardv2/public/js/external_lib/pnotify/pnotify.js PRE-CREATION 
  dashboardv2/public/js/main.js 3b7f2b22130f0df8ca4818ed65c58a48cc5fcbca 
  dashboardv2/public/js/models/VEntity.js ce86c243d7f4d1c1cc4e2c1e9a05bf393a3db5fe 
  dashboardv2/public/js/modules/atlasLogin.js 0fec3e44abcd4add1b5660fe3ecc3f295b2291d9 
  dashboardv2/public/js/utils/CommonViewFunction.js c0203ead522d25e1f54d0473fa687e3d497bfe99

  dashboardv2/public/js/utils/Messages.js 4bf404ecdeb379f7fbfea46c6bd2db1637f8c58a 
  dashboardv2/public/js/utils/UrlLinks.js 901de5a16d801d96c9e12cae61de16ee27e257e9 
  dashboardv2/public/js/utils/Utils.js 259ea2c8c15fe2c139097c8b5f4bf9c315a2086b 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 3f197cfeac7f0a9ee57393e232fb5a66682b68b6

  dashboardv2/public/js/views/graph/LineageLayoutView.js 7dae6d84785ac7d039120d895638925decb050f0

  dashboardv2/public/js/views/schema/SchemaLayoutView.js 8d7dfe44702fee4e37040f8b80df9b0d9f42d914

  dashboardv2/public/js/views/search/SearchResultLayoutView.js 23d74a5000b68af9fcd6fd4086deafdf9694e777

  dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 24e1e24423a9549fce3fbe47e5d0604277aa158c

  dashboardv2/public/js/views/tag/addTagModalView.js dcefc5a592b31ff776333ff6c000fbf68f888c01

  distro/src/conf/atlas-application.properties 7f79ad7589c5afdcd7fa12bc7476cc9417520d8a 
  intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java 602cdb4b6d29addb041eeaf93cae8623496bd768

  release-log.txt dc7d12e27e6bc3a1f128c591bc72c7d33721cdce 
  repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fd5dba78a9dbb2b38ed0a01c9844c58c91253f75

  repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
266f27c8e388cd8ad1a2f74f7dce14478d93f4ba 
  repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
b637f90967850319910c17f9017e62f68d14f546 
  repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 41dc65f5016e45a1fd4a0982e624932275ce31d1

  repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java 3677544d73183116cd0bea4a1b04be11f19b5c1a

  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 889236ca805142a93d9d4e63789fb0cc9aea05aa

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 855e402193ebf2d4ecd4cdb35129a9550e9a7638

  repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java 6655085ee11c94addca1564cf77bbdb001c4586f

  repository/src/main/java/org/apache/atlas/util/CompiledQueryCacheKey.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/util/NoopGremlinQuery.java PRE-CREATION 
  repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala daef5827bcfce99d8ffb7bf73bd6a7aa853626b9

  repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala a9dcdff2fb390e13cd5519d20d95f3c5d2b96669

  repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala ade4176b02c382920bddc24bb7ada28a52c30596

  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala a61ff982915684b72fe7067eea2fc2ac75d31baf

  repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala 5693c9ecc1a96154a8b0ac48256e5074dc041c5f

  repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java a0ee26c34517a441cfb7513d98852bd8d13ecca9

  repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java PRE-CREATION

  repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java PRE-CREATION

  repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 33513c5b33beb1a85d83eb65de687b91a1cf2b0f


Diff: https://reviews.apache.org/r/55443/diff/


Testing
-------

Ran all atlas tests, no regressions found.  There were some tests that failed both with and
without these changes.


Thanks,

Jeff Hagelberg


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message