atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 55830: ATLAS-1436 Metrics collection for Atlas
Date Mon, 23 Jan 2017 05:49:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55830/#review162591
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java (line 71)
<https://reviews.apache.org/r/55830/#comment233949>

    could consolidate line 68 and 71 to reduce map lookup twice.



repository/src/main/java/org/apache/atlas/services/MetricsService.java (line 96)
<https://reviews.apache.org/r/55830/#comment233947>

    any reason why expose only general metrics query in atlas-applic.properties and entitiy
specific queries here?



repository/src/main/java/org/apache/atlas/services/MetricsService.java (line 98)
<https://reviews.apache.org/r/55830/#comment233956>

    if there is not tags per entity does result of gremlin - key:value map return empty or
null values?


- Sarath Subramanian


On Jan. 22, 2017, 8:57 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55830/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2017, 8:57 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and
Vimal Sharma.
> 
> 
> Bugs: ATLAS-1436
>     https://issues.apache.org/jira/browse/ATLAS-1436
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1436: Metrics collection using gremlin
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasAdminClient.java 19f95758 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java d055b789 
>   distro/src/conf/atlas-application.properties 6fa066b6 
>   intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 02d74883 
>   webapp/src/main/resources/spring-security.xml 4ed88ece 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java eb2b2f6d

> 
> Diff: https://reviews.apache.org/r/55830/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -DskipITs executes successfully.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message