atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 55358: [ATLAS-1312] Update QuickStart to use the new APIs for type and entities creation
Date Sat, 21 Jan 2017 19:37:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55358/#review162563
-----------------------------------------------------------




distro/src/bin/quick_start.py (line 30)
<https://reviews.apache.org/r/55358/#comment233866>

    I think a seprate script for v2 might be useful. Existing script can be used to run against
earlier APIs.
    
    You can consider copying the existing script to quick_start_v1.py and have quick_start.py
use V2 APIs.



webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java (line 142)
<https://reviews.apache.org/r/55358/#comment233867>

    Consider adding an usage of LineageClient as well here.



webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java (line 152)
<https://reviews.apache.org/r/55358/#comment233868>

    Consider replacing reference to quick_start.py with the Java class name.



webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java (line 159)
<https://reviews.apache.org/r/55358/#comment233869>

    Consider moving these to start of the class, along with other static members.



webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java (line 337)
<https://reviews.apache.org/r/55358/#comment233870>

    CREATE_OR_UPDATE has been replaced with 'CREATE' and 'UPDATE' in a recent commit for ATLAS-1467.
Please review and update this usage accordingly.


- Madhan Neethiraj


On Jan. 19, 2017, 11:13 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55358/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 11:13 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1312
>     https://issues.apache.org/jira/browse/ATLAS-1312
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The quick start currently uses old APIs to create types and entities. This needs to be
updated to use the v2 APIs for types and entities.
> 
> 
> Diffs
> -----
> 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
9f33115 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java d055b78 
>   client/src/main/java/org/apache/atlas/AtlasLineageClientV2.java PRE-CREATION 
>   distro/src/bin/quick_start.py 14c8464 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java c866946 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 44d8a11 
> 
> Diff: https://reviews.apache.org/r/55358/diff/
> 
> 
> Testing
> -------
> 
> Tested using POstman REST Client and new ITs added
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message