atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 55697: ATLAS-1471: updated logging for better troubleshooting and reduce overhead
Date Thu, 19 Jan 2017 02:36:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55697/
-----------------------------------------------------------

(Updated Jan. 19, 2017, 2:36 a.m.)


Review request for atlas.


Changes
-------

addressed the review comments


Bugs: ATLAS-1471
    https://issues.apache.org/jira/browse/ATLAS-1471


Repository: atlas


Description
-------

- changed bunch of info level logs to debug level
- debug logs are now surrounded with "if (LOG.isDebugEnabled())", to reduce overhead
- for all REST API impl methods, added entry/exit debug logs
- for all REST API impl methods, added perf tracelog that include method argument values when
useful
   -- this perf logs can be enabled without requiring use of alternate binaries built with
a different profile


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 0d7487e 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
4220c35 
  repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
a6000cd 
  server-api/src/test/aspect/org/apache/atlas/MonitoredAspectTest.java a53d97c 
  typesystem/src/main/resources/atlas-log4j.xml a58898c 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java c20e978 
  webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java 8192b07

  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 7d65d97 
  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java c7aa372 
  webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java a5ef57d

  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java bbe660e 

Diff: https://reviews.apache.org/r/55697/diff/


Testing
-------

Verified that unit tests pass successfully
Deployed the binaries and validated that perf logs are generated as designed (sample below):
  2017-01-17 22:19:27,100|pool-1-thread-8 - ec78c9ca-6c25-43b6-8c12-7fcacb4aa236|PERF|MetadataDiscoveryResource.searchUsingQueryDSL(`tag1`,
25, -1)|1710
  2017-01-17 22:19:39,704|pool-1-thread-4 - e5785a03-cb74-4d72-bba7-ae5304a2c083|PERF|MetadataDiscoveryResource.searchUsingQueryDSL(hive_table,
25, -1)|397
  2017-01-17 22:19:44,620|pool-1-thread-6 - 96af876f-9cc2-4baa-8928-12fb1cee7597|PERF|EntityResource.getAuditEvents(22ace873-a299-4c5c-9a9f-fdd8b45a1d53,
null, 26)|90
  2017-01-17 22:19:45,225|pool-1-thread-8 - 93a25a01-74a0-4f39-9d74-bb3c66fa65c1|PERF|LineageResource.schema(22ace873-a299-4c5c-9a9f-fdd8b45a1d53)|788
  2017-01-17 22:20:05,480|pool-1-thread-5 - dc47f23c-c50c-4402-82da-ded0c8707a45|PERF|MetadataDiscoveryResource.searchUsingQueryDSL(hive_table,
25, -1)|371
  2017-01-17 22:20:07,261|pool-1-thread-6 - fc0a70e5-8033-4c5d-a52f-b98e5f88ac66|PERF|EntityResource.getAuditEvents(f87b1576-c502-46bf-92d6-2a8c80836854,
null, 26)|13
  2017-01-17 22:20:07,660|pool-1-thread-7 - db904c83-80b8-4dc6-bbfc-8fba04c38f42|PERF|LineageResource.schema(f87b1576-c502-46bf-92d6-2a8c80836854)|484


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message